From: Segher Boessenkool <segher@kernel.crashing.org>
To: Simon Vallet <linux-ppc@castalie.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: R_PPC_ADDR16_HI relocs in PPC modules ?
Date: Tue, 2 Jan 2007 18:16:01 +0100 [thread overview]
Message-ID: <535725c5c6010b6283b0ed0826dd469d@kernel.crashing.org> (raw)
In-Reply-To: <20070102172554.7a94cd37@mlejnas.priv.castalie.org>
> unknown ADD relocation: 5
>
> which refers to R_PPC_ADDR16_HI relocations. The error message comes
> from apply_relocate_add() in arch/powerpc/kernel/module_32.c, which
> deals with R_PPC_ADDR16_LO and R_PPC_ADDR16_HA relocs, but not
> R_PPC_ADDR16_HI ones.
>
> Is there a reason for this ? Those relocs directly come from the
> mapping of PPC_RELOC_HI16 in the original driver, and i'd rather not
> transpose them into R_PPC_ADDR16_HA.
Well you normally never end up with an add with an @h -- you're
typically adding it to something that is loaded with "li", i.e.,
something that's the sign-extended version of the low 16 bits of
the 32-bit thing you're loading totally.
I'm interested how (and why :-) ) Darwin ends up doing it; could
you send me the (original) file in question? Or an otool -tvV
of it, or part thereof that shows the problem.
Segher
next prev parent reply other threads:[~2007-01-02 17:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-02 16:25 R_PPC_ADDR16_HI relocs in PPC modules ? Simon Vallet
2007-01-02 17:16 ` Segher Boessenkool [this message]
2007-01-02 18:09 ` Simon Vallet
2007-01-02 20:48 ` Segher Boessenkool
2007-01-03 0:47 ` Paul Mackerras
2007-01-03 1:20 ` Segher Boessenkool
2007-01-02 20:41 ` Benjamin Herrenschmidt
2007-01-03 7:01 ` Simon Vallet
2007-01-03 9:58 ` Benjamin Herrenschmidt
2007-01-03 10:32 ` Simon Vallet
2007-01-03 20:36 ` Benjamin Herrenschmidt
2007-01-02 21:31 ` Alan Modra
2007-01-03 6:49 ` [PATCH] Add support for R_PPC_ADDR16_HI relocations Simon Vallet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=535725c5c6010b6283b0ed0826dd469d@kernel.crashing.org \
--to=segher@kernel.crashing.org \
--cc=linux-ppc@castalie.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).