From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1lp0140.outbound.protection.outlook.com [207.46.163.140]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 9C44914015E for ; Sun, 4 May 2014 18:55:38 +1000 (EST) Message-ID: <5365FCF2.9090008@freescale.com> Date: Sun, 4 May 2014 16:40:18 +0800 From: Hongbo Zhang MIME-Version: 1.0 To: Vinod Koul Subject: Re: [PATCH v4 7/8] DMA: Freescale: use spin_lock_bh instead of spin_lock_irqsave References: <1397809071-5353-1-git-send-email-hongbo.zhang@freescale.com> <1397809071-5353-8-git-send-email-hongbo.zhang@freescale.com> <20140502165143.GI32284@intel.com> In-Reply-To: <20140502165143.GI32284@intel.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Cc: leo.li@freescale.com, vkoul@infradead.org, linux-kernel@vger.kernel.org, scottwood@freescale.com, dmaengine@vger.kernel.org, dan.j.williams@intel.com, linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 05/03/2014 12:51 AM, Vinod Koul wrote: > On Fri, Apr 18, 2014 at 04:17:50PM +0800, hongbo.zhang@freescale.com wrote: >> From: Hongbo Zhang >> >> The usage of spin_lock_irqsave() is a stronger locking mechanism than is >> required throughout the driver. The minimum locking required should be used >> instead. Interrupts will be turned off and context will be saved, it is >> unnecessary to use irqsave. >> >> This patch changes all instances of spin_lock_irqsave() to spin_lock_bh(). All >> manipulation of protected fields is done using tasklet context or weaker, which >> makes spin_lock_bh() the correct choice. >> > This doesnt apply, perhpas due to depends on 6/8 > So let's wait for the review result of 6/8.