From: Alexander Graf <agraf@suse.de>
To: Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@lists.ozlabs.org,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
kvm-ppc@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH V4] POWERPC: BOOK3S: KVM: Use the saved dar value and generic make_dsisr
Date: Tue, 06 May 2014 08:57:51 +0200 [thread overview]
Message-ID: <536887EF.2070201@suse.de> (raw)
In-Reply-To: <20140506004133.GA12595@iris.ozlabs.ibm.com>
On 06.05.14 02:41, Paul Mackerras wrote:
> On Mon, May 05, 2014 at 01:19:30PM +0200, Alexander Graf wrote:
>> On 05/04/2014 07:21 PM, Aneesh Kumar K.V wrote:
>>> +#ifdef CONFIG_PPC_BOOK3S_64
>>> + return vcpu->arch.fault_dar;
>> How about PA6T and G5s?
> G5 sets DAR on an alignment interrupt.
>
> As for PA6T, I don't know for sure, but if it doesn't, ordinary
> alignment interrupts wouldn't be handled properly, since the code in
> arch/powerpc/kernel/align.c assumes DAR contains the address being
> accessed on all PowerPC CPUs.
Now that's a good point. If we simply behave like Linux, I'm fine. This
definitely deserves a comment on the #ifdef in the code.
Alex
next prev parent reply other threads:[~2014-05-06 6:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-04 17:21 [PATCH V4] POWERPC: BOOK3S: KVM: Use the saved dar value and generic make_dsisr Aneesh Kumar K.V
2014-05-05 11:19 ` Alexander Graf
2014-05-05 14:26 ` Aneesh Kumar K.V
2014-05-05 14:43 ` Alexander Graf
2014-05-05 14:50 ` Aneesh Kumar K.V
2014-05-05 15:10 ` Alexander Graf
2014-05-05 14:54 ` Olof Johansson
2014-05-05 15:03 ` Aneesh Kumar K.V
2014-05-05 15:06 ` Olof Johansson
2014-05-05 14:57 ` Olof Johansson
2014-05-05 15:09 ` Alexander Graf
2014-05-05 21:23 ` Christian Zigotzky
2014-05-06 0:07 ` Benjamin Herrenschmidt
2014-05-06 0:04 ` Benjamin Herrenschmidt
2014-05-06 0:41 ` Paul Mackerras
2014-05-06 6:57 ` Alexander Graf [this message]
2014-05-06 14:06 ` Aneesh Kumar K.V
2014-05-06 14:12 ` Aneesh Kumar K.V
2014-05-06 14:21 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536887EF.2070201@suse.de \
--to=agraf@suse.de \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).