From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e39.co.us.ibm.com (e39.co.us.ibm.com [32.97.110.160]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 62B30140080 for ; Tue, 13 May 2014 17:12:50 +1000 (EST) Received: from /spool/local by e39.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 13 May 2014 01:12:44 -0600 Received: from b01cxnp22034.gho.pok.ibm.com (b01cxnp22034.gho.pok.ibm.com [9.57.198.24]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id 967916E801C for ; Tue, 13 May 2014 03:12:34 -0400 (EDT) Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by b01cxnp22034.gho.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s4D7Cgl22687366 for ; Tue, 13 May 2014 07:12:42 GMT Received: from d01av04.pok.ibm.com (localhost [127.0.0.1]) by d01av04.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s4D7CfPp014114 for ; Tue, 13 May 2014 03:12:41 -0400 Message-ID: <5371C5E5.6070701@linux.vnet.ibm.com> Date: Tue, 13 May 2014 00:12:37 -0700 From: Cody P Schafer MIME-Version: 1.0 To: Michael Neuling Subject: Re: [PATCH] powerpc/pseries: relocate "config DTL" so KConfig nests properly References: <1399950599-24826-1-git-send-email-cody@linux.vnet.ibm.com> <1399962216.7554.63.camel@ale.ozlabs.ibm.com> In-Reply-To: <1399962216.7554.63.camel@ale.ozlabs.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Cc: Deepthi Dharwar , Paul Bolle , Gavin Shan , Li Zhong , linux-kernel@vger.kernel.org, Paul Mackerras , "Srivatsa S. Bhat" , linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 05/12/2014 11:23 PM, Michael Neuling wrote: >> powerpc/pseries: relocate "config DTL" so KConfig nests properly > > I don't know what that means. Can you describe it in more detail? > So the "config DTL" refers to the configuration entry. The "nests properly" refers to the indent that 'make menuconfig' shows when a config-option that depends on the config-option proceeding it. In this case, moving config DTL up so it is below config PPC_SPLPAR means that menuconfig will show config DTL nicely indented right below config PPC_SPLPAR when PPC_SPLPAR is enabled. To contrast that, right now if I enable PPC_SPLPAR in menuconfig, all I can immediately tell is that "something showed up further down the list where I wasn't looking", and I end up having to toggle the option a few times to figure out what showed up, or look at the KConfig to find out that config DTL depends on config PPC_SPLPAR. Essentially, this enables menuconfig to provide a visual hint about the dependencies between options. > Mikey > > > On Mon, 2014-05-12 at 20:09 -0700, Cody P Schafer wrote: >> Signed-off-by: Cody P Schafer >> --- >> arch/powerpc/platforms/pseries/Kconfig | 20 ++++++++++---------- >> 1 file changed, 10 insertions(+), 10 deletions(-) >> >> diff --git a/arch/powerpc/platforms/pseries/Kconfig b/arch/powerpc/platforms/pseries/Kconfig >> index 2cb8b77..e00dd4d 100644 >> --- a/arch/powerpc/platforms/pseries/Kconfig >> +++ b/arch/powerpc/platforms/pseries/Kconfig >> @@ -33,6 +33,16 @@ config PPC_SPLPAR >> processors, that is, which share physical processors between >> two or more partitions. >> >> +config DTL >> + bool "Dispatch Trace Log" >> + depends on PPC_SPLPAR && DEBUG_FS >> + help >> + SPLPAR machines can log hypervisor preempt & dispatch events to a >> + kernel buffer. Saying Y here will enable logging these events, >> + which are accessible through a debugfs file. >> + >> + Say N if you are unsure. >> + >> config PSERIES_MSI >> bool >> depends on PCI_MSI && PPC_PSERIES && EEH >> @@ -122,13 +132,3 @@ config HV_PERF_CTRS >> systems. 24x7 is available on Power 8 systems. >> >> If unsure, select Y. >> - >> -config DTL >> - bool "Dispatch Trace Log" >> - depends on PPC_SPLPAR && DEBUG_FS >> - help >> - SPLPAR machines can log hypervisor preempt & dispatch events to a >> - kernel buffer. Saying Y here will enable logging these events, >> - which are accessible through a debugfs file. >> - >> - Say N if you are unsure. >