From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 0738B1A007E for ; Mon, 19 May 2014 22:55:45 +1000 (EST) Message-ID: <5379FF4C.7080202@suse.de> Date: Mon, 19 May 2014 14:55:40 +0200 From: Alexander Graf MIME-Version: 1.0 To: Gavin Shan , kvm-ppc@vger.kernel.org Subject: Re: [PATCH 6/8] powerpc: Extend syscall ppc_rtas() References: <1400040722-29608-1-git-send-email-gwshan@linux.vnet.ibm.com> <1400040722-29608-7-git-send-email-gwshan@linux.vnet.ibm.com> In-Reply-To: <1400040722-29608-7-git-send-email-gwshan@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Cc: aik@ozlabs.ru, alex.williamson@redhat.com, qiudayu@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 14.05.14 06:12, Gavin Shan wrote: > Originally, syscall ppc_rtas() can be used to invoke RTAS call from > user space. Utility "errinjct" is using it to inject various errors > to the system for testing purpose. The patch intends to extend the > syscall to support both pSeries and PowerNV platform. With that, > RTAS and OPAL call can be invoked from user space. In turn, utility > "errinjct" can be supported on pSeries and PowerNV platform at same > time. > > The original syscall handler ppc_rtas() is renamed to ppc_firmware(), > which calls ppc_call_rtas() or ppc_call_opal() depending on the > running platform. The data transported between userland and kerenl is Please fix your spelling of kernel. > by "struct rtas_args". It's platform specific on how to use the data. > > Signed-off-by: Mike Qiu > Signed-off-by: Gavin Shan I think the basic idea to maintain the same interface between PAPR and OPAL to user space is sound, but this is really Ben's call. Alex