From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-la0-f46.google.com (mail-la0-f46.google.com [209.85.215.46]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 939561A0083 for ; Fri, 23 May 2014 03:21:30 +1000 (EST) Received: by mail-la0-f46.google.com with SMTP id ec20so1285201lab.5 for ; Thu, 22 May 2014 10:21:24 -0700 (PDT) Message-ID: <537E3218.6030104@cogentembedded.com> Date: Thu, 22 May 2014 21:21:28 +0400 From: Sergei Shtylyov MIME-Version: 1.0 To: Florian Fainelli Subject: Re: [PATCH RESEND net-next 4/9] net: systemport: use the new fixed PHY helpers References: <1400708331-18088-1-git-send-email-f.fainelli@gmail.com> <1400708331-18088-5-git-send-email-f.fainelli@gmail.com> <537D20EA.1000305@cogentembedded.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Cc: Thomas Petazzoni , "open list:OPEN FIRMWARE AND..." , Aida Mynzhasova , netdev , Richard Cochran , open list , Claudiu Manoil , Vitaly Bordug , Grant Likely , "open list:LINUX FOR POWERPC..." , David Miller List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hello. On 05/22/2014 02:02 AM, Florian Fainelli wrote: >>> of_phy_connect_fixed_link() is becoming obsolete, and also required >>> platform code to register the fixed PHYs at the specified addresses for >>> those to be usable. Get rid of it and use the new of_phy_is_fixed_link() >>> plus of_phy_register_fixed_link() helpers to transition over the new >>> scheme. >>> Signed-off-by: Florian Fainelli >>> --- >>> drivers/net/ethernet/broadcom/bcmsysport.c | 17 +++++++++++++++-- >>> drivers/net/ethernet/broadcom/bcmsysport.h | 1 + >>> 2 files changed, 16 insertions(+), 2 deletions(-) >>> diff --git a/drivers/net/ethernet/broadcom/bcmsysport.c >>> b/drivers/net/ethernet/broadcom/bcmsysport.c >>> index d40c5b969e9e..dc708a888f80 100644 >>> --- a/drivers/net/ethernet/broadcom/bcmsysport.c >>> +++ b/drivers/net/ethernet/broadcom/bcmsysport.c >>> @@ -1327,8 +1327,8 @@ static int bcm_sysport_open(struct net_device *dev) >>> /* Read CRC forward */ >>> priv->crc_fwd = !!(umac_readl(priv, UMAC_CMD) & CMD_CRC_FWD); >>> >>> - priv->phydev = of_phy_connect_fixed_link(dev, >>> bcm_sysport_adj_link, >>> - >>> priv->phy_interface); >>> + priv->phydev = of_phy_connect(dev, priv->phy_dn, >>> bcm_sysport_adj_link, >>> + 0, priv->phy_interface); >> The continuation line should start on the next character after ( on the >> above line, according to the networking coding style. > Unless I am once again not following the coding style, the patch in > patchwork has this correctly, and so does my file locally: > http://patchwork.ozlabs.org/patch/351323/ Don't know about your local file but the patchwork still has the indentation wrong. -- you've used only tabs while the last several characters should have been spaces. However, if David himself finds it correct, I guess I just need to shut up. :-) WBR, Sergei