linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: Michael Neuling <mikey@neuling.org>
Cc: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org,
	Paul Mackerras <paulus@samba.org>,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2 0/6] Implement split core for POWER8
Date: Fri, 23 May 2014 12:27:23 +0200	[thread overview]
Message-ID: <537F228B.1030308@suse.de> (raw)
In-Reply-To: <1400839918.28224.11.camel@ale.ozlabs.ibm.com>


On 23.05.14 12:11, Michael Neuling wrote:
>>>> Also, is there any performance penalty associated with split core mode?
>>>> If not, could we just always default to split-by-4 on POWER8 bare metal?
>>> Yeah, there is a performance hit .  When you are split (ie
>>> subcores_per_core = 2 or 4), the core is stuck in SMT8 mode.  So if you
>>> only have 1 thread active (others napped), you won't get the benefit of
>>> ST mode in the core (more register renames per HW thread, more FXUs,
>>> more FPUs etc).
>> Ok, imagine I have 1 core with SMT8. I have one process running at 100%
>> occupying one thread, the other 7 threads are idle.
>>
>> Do I get performance benefits from having the other threads idle? Or do
>> I have to configure the system into SMT1 mode to get my ST benefits?
> You automatically get the performance benefit when they are idle.  When
> threads enter nap, the core is able to reduce it's SMT mode
> automatically.

Unless in split core mode - meh. That's a real bummer then, yeah.


>
>> If it's the latter, we could just have ppc64_cpu --smt=x also set the
>> subcore amount in parallel to the thread count.
> FWIW on powernv we just nap the threads on hotplug.
>
>> The reason I'm bringing this up is that I'm not quite sure who would be
>> the instance doing these performance tweaks. So I'd guess the majority
>> of users will simply miss out on them.
> Everyone, it's automatic on idle... except for split core mode
> unfortunately.

Oh I meant when you want to use a POWER system as VM host, you have to 
know about split core mode and configure it accordingly. That's 
something someone needs to do. And it's different from x86 which means 
people may miss out on it for their performance benchmarks.

But if we impose a general performance penalty for everyone with it, I 
don't think split core mode should be enabled by default.


Alex

  reply	other threads:[~2014-05-23 10:27 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-23  8:15 [PATCH v2 0/6] Implement split core for POWER8 Michael Neuling
2014-05-23  8:15 ` [PATCH v2 1/6] KVM: PPC: Book3S HV: Rework the secondary inhibit code Michael Neuling
2014-05-23  8:15 ` [PATCH v2 2/6] powerpc/powernv: Make it possible to skip the IRQHAPPENED check in power7_nap() Michael Neuling
2014-05-23  8:15 ` [PATCH v2 3/6] powerpc: Add threads_per_subcore Michael Neuling
2014-05-23  8:15 ` [PATCH v2 4/6] powerpc: Check cpu_thread_in_subcore() in __cpu_up() Michael Neuling
2014-05-23  8:15 ` [PATCH v2 5/6] KVM: PPC: Book3S HV: Use threads_per_subcore in KVM Michael Neuling
2014-05-23  8:15 ` [PATCH v2 6/6] powerpc/powernv: Add support for POWER8 split core on powernv Michael Neuling
2014-05-23  9:53 ` [PATCH v2 0/6] Implement split core for POWER8 Alexander Graf
2014-05-23 10:00   ` Michael Neuling
2014-05-23 10:05     ` Alexander Graf
2014-05-23 10:11       ` Michael Neuling
2014-05-23 10:27         ` Alexander Graf [this message]
2014-05-23 10:50           ` Michael Neuling

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=537F228B.1030308@suse.de \
    --to=agraf@suse.de \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mikey@neuling.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).