* powerpc/pseries: Use new defines when calling h_set_mode
[not found] ` <BD1CF085-FEBC-4208-AD3F-C55DB002097F@suse.de>
@ 2014-05-29 7:45 ` Michael Neuling
2014-05-29 21:27 ` Alexander Graf
2014-05-30 8:56 ` Michael Ellerman
0 siblings, 2 replies; 9+ messages in thread
From: Michael Neuling @ 2014-05-29 7:45 UTC (permalink / raw)
To: Alexander Graf
Cc: linuxppc-dev, Paul Mackerras, kvm@vger.kernel.org,
kvm-ppc@vger.kernel.org
> > +/* Values for 2nd argument to H_SET_MODE */
> > +#define H_SET_MODE_RESOURCE_SET_CIABR 1
> > +#define H_SET_MODE_RESOURCE_SET_DAWR 2
> > +#define H_SET_MODE_RESOURCE_ADDR_TRANS_MODE 3
> > +#define H_SET_MODE_RESOURCE_LE 4
>=20
>=20
> Much better, but I think you want to make use of these in non-kvm code to=
o,
> no? At least the LE one is definitely already implemented as call :)
Sure but that's a different patch.... below.
Mikey
powerpc/pseries: Use new defines when calling h_set_mode
Now that we define these in the KVM code, use these defines when we call
h_set_mode. No functional change.
Signed-off-by: Michael Neuling <mikey@neuling.org>
--
This depends on the KVM h_set_mode patches.
diff --git a/arch/powerpc/include/asm/plpar_wrappers.h b/arch/powerpc/inclu=
de/asm/plpar_wrappers.h
index 12c32c5..67859ed 100644
--- a/arch/powerpc/include/asm/plpar_wrappers.h
+++ b/arch/powerpc/include/asm/plpar_wrappers.h
@@ -273,7 +273,7 @@ static inline long plpar_set_mode(unsigned long mflags,=
unsigned long resource,
static inline long enable_reloc_on_exceptions(void)
{
/* mflags =3D 3: Exceptions at 0xC000000000004000 */
- return plpar_set_mode(3, 3, 0, 0);
+ return plpar_set_mode(3, H_SET_MODE_RESOURCE_ADDR_TRANS_MODE, 0, 0);
}
=20
/*
@@ -284,7 +284,7 @@ static inline long enable_reloc_on_exceptions(void)
* returns H_SUCCESS.
*/
static inline long disable_reloc_on_exceptions(void) {
- return plpar_set_mode(0, 3, 0, 0);
+ return plpar_set_mode(0, H_SET_MODE_RESOURCE_ADDR_TRANS_MODE, 0, 0);
}
=20
/*
@@ -297,7 +297,7 @@ static inline long disable_reloc_on_exceptions(void) {
static inline long enable_big_endian_exceptions(void)
{
/* mflags =3D 0: big endian exceptions */
- return plpar_set_mode(0, 4, 0, 0);
+ return plpar_set_mode(0, H_SET_MODE_RESOURCE_LE, 0, 0);
}
=20
/*
@@ -310,17 +310,17 @@ static inline long enable_big_endian_exceptions(void)
static inline long enable_little_endian_exceptions(void)
{
/* mflags =3D 1: little endian exceptions */
- return plpar_set_mode(1, 4, 0, 0);
+ return plpar_set_mode(1, H_SET_MODE_RESOURCE_LE, 0, 0);
}
=20
static inline long plapr_set_ciabr(unsigned long ciabr)
{
- return plpar_set_mode(0, 1, ciabr, 0);
+ return plpar_set_mode(0, H_SET_MODE_RESOURCE_SET_CIABR, ciabr, 0);
}
=20
static inline long plapr_set_watchpoint0(unsigned long dawr0, unsigned lon=
g dawrx0)
{
- return plpar_set_mode(0, 2, dawr0, dawrx0);
+ return plpar_set_mode(0, H_SET_MODE_RESOURCE_SET_DAWR, dawr0, dawrx0);
}
=20
#endif /* _ASM_POWERPC_PLPAR_WRAPPERS_H */
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: powerpc/pseries: Use new defines when calling h_set_mode
2014-05-29 7:45 ` powerpc/pseries: Use new defines when calling h_set_mode Michael Neuling
@ 2014-05-29 21:27 ` Alexander Graf
2014-05-29 21:52 ` Benjamin Herrenschmidt
2014-05-30 8:56 ` Michael Ellerman
1 sibling, 1 reply; 9+ messages in thread
From: Alexander Graf @ 2014-05-29 21:27 UTC (permalink / raw)
To: Michael Neuling
Cc: linuxppc-dev, Paul Mackerras, kvm@vger.kernel.org,
kvm-ppc@vger.kernel.org
On 29.05.14 09:45, Michael Neuling wrote:
>>> +/* Values for 2nd argument to H_SET_MODE */
>>> +#define H_SET_MODE_RESOURCE_SET_CIABR 1
>>> +#define H_SET_MODE_RESOURCE_SET_DAWR 2
>>> +#define H_SET_MODE_RESOURCE_ADDR_TRANS_MODE 3
>>> +#define H_SET_MODE_RESOURCE_LE 4
>>
>> Much better, but I think you want to make use of these in non-kvm code too,
>> no? At least the LE one is definitely already implemented as call :)
> Sure but that's a different patch.... below.
Ben, how would you like to handle these 2 patches? If you give me an ack
I can just put this patch into my kvm queue. Alternatively we could both
carry a patch that adds the H_SET_MODE header bits only and whoever hits
Linus' tree first wins ;).
Alex
>
> Mikey
>
>
> powerpc/pseries: Use new defines when calling h_set_mode
>
> Now that we define these in the KVM code, use these defines when we call
> h_set_mode. No functional change.
>
> Signed-off-by: Michael Neuling <mikey@neuling.org>
> --
> This depends on the KVM h_set_mode patches.
>
> diff --git a/arch/powerpc/include/asm/plpar_wrappers.h b/arch/powerpc/include/asm/plpar_wrappers.h
> index 12c32c5..67859ed 100644
> --- a/arch/powerpc/include/asm/plpar_wrappers.h
> +++ b/arch/powerpc/include/asm/plpar_wrappers.h
> @@ -273,7 +273,7 @@ static inline long plpar_set_mode(unsigned long mflags, unsigned long resource,
> static inline long enable_reloc_on_exceptions(void)
> {
> /* mflags = 3: Exceptions at 0xC000000000004000 */
> - return plpar_set_mode(3, 3, 0, 0);
> + return plpar_set_mode(3, H_SET_MODE_RESOURCE_ADDR_TRANS_MODE, 0, 0);
> }
>
> /*
> @@ -284,7 +284,7 @@ static inline long enable_reloc_on_exceptions(void)
> * returns H_SUCCESS.
> */
> static inline long disable_reloc_on_exceptions(void) {
> - return plpar_set_mode(0, 3, 0, 0);
> + return plpar_set_mode(0, H_SET_MODE_RESOURCE_ADDR_TRANS_MODE, 0, 0);
> }
>
> /*
> @@ -297,7 +297,7 @@ static inline long disable_reloc_on_exceptions(void) {
> static inline long enable_big_endian_exceptions(void)
> {
> /* mflags = 0: big endian exceptions */
> - return plpar_set_mode(0, 4, 0, 0);
> + return plpar_set_mode(0, H_SET_MODE_RESOURCE_LE, 0, 0);
> }
>
> /*
> @@ -310,17 +310,17 @@ static inline long enable_big_endian_exceptions(void)
> static inline long enable_little_endian_exceptions(void)
> {
> /* mflags = 1: little endian exceptions */
> - return plpar_set_mode(1, 4, 0, 0);
> + return plpar_set_mode(1, H_SET_MODE_RESOURCE_LE, 0, 0);
> }
>
> static inline long plapr_set_ciabr(unsigned long ciabr)
> {
> - return plpar_set_mode(0, 1, ciabr, 0);
> + return plpar_set_mode(0, H_SET_MODE_RESOURCE_SET_CIABR, ciabr, 0);
> }
>
> static inline long plapr_set_watchpoint0(unsigned long dawr0, unsigned long dawrx0)
> {
> - return plpar_set_mode(0, 2, dawr0, dawrx0);
> + return plpar_set_mode(0, H_SET_MODE_RESOURCE_SET_DAWR, dawr0, dawrx0);
> }
>
> #endif /* _ASM_POWERPC_PLPAR_WRAPPERS_H */
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: powerpc/pseries: Use new defines when calling h_set_mode
2014-05-29 21:27 ` Alexander Graf
@ 2014-05-29 21:52 ` Benjamin Herrenschmidt
2014-05-30 7:44 ` Alexander Graf
0 siblings, 1 reply; 9+ messages in thread
From: Benjamin Herrenschmidt @ 2014-05-29 21:52 UTC (permalink / raw)
To: Alexander Graf
Cc: linuxppc-dev, Michael Neuling, Paul Mackerras,
kvm@vger.kernel.org, kvm-ppc@vger.kernel.org
On Thu, 2014-05-29 at 23:27 +0200, Alexander Graf wrote:
> On 29.05.14 09:45, Michael Neuling wrote:
> >>> +/* Values for 2nd argument to H_SET_MODE */
> >>> +#define H_SET_MODE_RESOURCE_SET_CIABR 1
> >>> +#define H_SET_MODE_RESOURCE_SET_DAWR 2
> >>> +#define H_SET_MODE_RESOURCE_ADDR_TRANS_MODE 3
> >>> +#define H_SET_MODE_RESOURCE_LE 4
> >>
> >> Much better, but I think you want to make use of these in non-kvm code too,
> >> no? At least the LE one is definitely already implemented as call :)
> > Sure but that's a different patch.... below.
>
> Ben, how would you like to handle these 2 patches? If you give me an ack
> I can just put this patch into my kvm queue. Alternatively we could both
> carry a patch that adds the H_SET_MODE header bits only and whoever hits
> Linus' tree first wins ;).
No biggie. Worst case it's a trivial conflict.
Cheers,
Ben.
>
> Alex
>
> >
> > Mikey
> >
> >
> > powerpc/pseries: Use new defines when calling h_set_mode
> >
> > Now that we define these in the KVM code, use these defines when we call
> > h_set_mode. No functional change.
> >
> > Signed-off-by: Michael Neuling <mikey@neuling.org>
> > --
> > This depends on the KVM h_set_mode patches.
> >
> > diff --git a/arch/powerpc/include/asm/plpar_wrappers.h b/arch/powerpc/include/asm/plpar_wrappers.h
> > index 12c32c5..67859ed 100644
> > --- a/arch/powerpc/include/asm/plpar_wrappers.h
> > +++ b/arch/powerpc/include/asm/plpar_wrappers.h
> > @@ -273,7 +273,7 @@ static inline long plpar_set_mode(unsigned long mflags, unsigned long resource,
> > static inline long enable_reloc_on_exceptions(void)
> > {
> > /* mflags = 3: Exceptions at 0xC000000000004000 */
> > - return plpar_set_mode(3, 3, 0, 0);
> > + return plpar_set_mode(3, H_SET_MODE_RESOURCE_ADDR_TRANS_MODE, 0, 0);
> > }
> >
> > /*
> > @@ -284,7 +284,7 @@ static inline long enable_reloc_on_exceptions(void)
> > * returns H_SUCCESS.
> > */
> > static inline long disable_reloc_on_exceptions(void) {
> > - return plpar_set_mode(0, 3, 0, 0);
> > + return plpar_set_mode(0, H_SET_MODE_RESOURCE_ADDR_TRANS_MODE, 0, 0);
> > }
> >
> > /*
> > @@ -297,7 +297,7 @@ static inline long disable_reloc_on_exceptions(void) {
> > static inline long enable_big_endian_exceptions(void)
> > {
> > /* mflags = 0: big endian exceptions */
> > - return plpar_set_mode(0, 4, 0, 0);
> > + return plpar_set_mode(0, H_SET_MODE_RESOURCE_LE, 0, 0);
> > }
> >
> > /*
> > @@ -310,17 +310,17 @@ static inline long enable_big_endian_exceptions(void)
> > static inline long enable_little_endian_exceptions(void)
> > {
> > /* mflags = 1: little endian exceptions */
> > - return plpar_set_mode(1, 4, 0, 0);
> > + return plpar_set_mode(1, H_SET_MODE_RESOURCE_LE, 0, 0);
> > }
> >
> > static inline long plapr_set_ciabr(unsigned long ciabr)
> > {
> > - return plpar_set_mode(0, 1, ciabr, 0);
> > + return plpar_set_mode(0, H_SET_MODE_RESOURCE_SET_CIABR, ciabr, 0);
> > }
> >
> > static inline long plapr_set_watchpoint0(unsigned long dawr0, unsigned long dawrx0)
> > {
> > - return plpar_set_mode(0, 2, dawr0, dawrx0);
> > + return plpar_set_mode(0, H_SET_MODE_RESOURCE_SET_DAWR, dawr0, dawrx0);
> > }
> >
> > #endif /* _ASM_POWERPC_PLPAR_WRAPPERS_H */
> >
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: powerpc/pseries: Use new defines when calling h_set_mode
2014-05-29 21:52 ` Benjamin Herrenschmidt
@ 2014-05-30 7:44 ` Alexander Graf
0 siblings, 0 replies; 9+ messages in thread
From: Alexander Graf @ 2014-05-30 7:44 UTC (permalink / raw)
To: Benjamin Herrenschmidt
Cc: linuxppc-dev, Michael Neuling, Paul Mackerras,
kvm@vger.kernel.org, kvm-ppc@vger.kernel.org
On 29.05.14 23:52, Benjamin Herrenschmidt wrote:
> On Thu, 2014-05-29 at 23:27 +0200, Alexander Graf wrote:
>> On 29.05.14 09:45, Michael Neuling wrote:
>>>>> +/* Values for 2nd argument to H_SET_MODE */
>>>>> +#define H_SET_MODE_RESOURCE_SET_CIABR 1
>>>>> +#define H_SET_MODE_RESOURCE_SET_DAWR 2
>>>>> +#define H_SET_MODE_RESOURCE_ADDR_TRANS_MODE 3
>>>>> +#define H_SET_MODE_RESOURCE_LE 4
>>>> Much better, but I think you want to make use of these in non-kvm code too,
>>>> no? At least the LE one is definitely already implemented as call :)
>>> Sure but that's a different patch.... below.
>> Ben, how would you like to handle these 2 patches? If you give me an ack
>> I can just put this patch into my kvm queue. Alternatively we could both
>> carry a patch that adds the H_SET_MODE header bits only and whoever hits
>> Linus' tree first wins ;).
> No biggie. Worst case it's a trivial conflict.
Well, the way the patches are split right now it won't be a conflict,
but a build failure on either side.
Alex
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: powerpc/pseries: Use new defines when calling h_set_mode
2014-05-29 7:45 ` powerpc/pseries: Use new defines when calling h_set_mode Michael Neuling
2014-05-29 21:27 ` Alexander Graf
@ 2014-05-30 8:56 ` Michael Ellerman
2014-05-30 9:10 ` Michael Neuling
1 sibling, 1 reply; 9+ messages in thread
From: Michael Ellerman @ 2014-05-30 8:56 UTC (permalink / raw)
To: Michael Neuling
Cc: kvm-ppc@vger.kernel.org, Paul Mackerras, linuxppc-dev,
Alexander Graf, kvm@vger.kernel.org
On Thu, 2014-05-29 at 17:45 +1000, Michael Neuling wrote:
> > > +/* Values for 2nd argument to H_SET_MODE */
> > > +#define H_SET_MODE_RESOURCE_SET_CIABR 1
> > > +#define H_SET_MODE_RESOURCE_SET_DAWR 2
> > > +#define H_SET_MODE_RESOURCE_ADDR_TRANS_MODE 3
> > > +#define H_SET_MODE_RESOURCE_LE 4
> >
> > Much better, but I think you want to make use of these in non-kvm code too,
> > no? At least the LE one is definitely already implemented as call :)
>
> powerpc/pseries: Use new defines when calling h_set_mode
>
> Now that we define these in the KVM code, use these defines when we call
> h_set_mode. No functional change.
>
> Signed-off-by: Michael Neuling <mikey@neuling.org>
> --
> This depends on the KVM h_set_mode patches.
>
> diff --git a/arch/powerpc/include/asm/plpar_wrappers.h b/arch/powerpc/include/asm/plpar_wrappers.h
> index 12c32c5..67859ed 100644
> --- a/arch/powerpc/include/asm/plpar_wrappers.h
> +++ b/arch/powerpc/include/asm/plpar_wrappers.h
> @@ -273,7 +273,7 @@ static inline long plpar_set_mode(unsigned long mflags, unsigned long resource,
> static inline long enable_reloc_on_exceptions(void)
> {
> /* mflags = 3: Exceptions at 0xC000000000004000 */
> - return plpar_set_mode(3, 3, 0, 0);
> + return plpar_set_mode(3, H_SET_MODE_RESOURCE_ADDR_TRANS_MODE, 0, 0);
> }
Which header are these coming from, and why aren't we including it? And is it
going to still build with CONFIG_KVM=n?
cheers
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: powerpc/pseries: Use new defines when calling h_set_mode
2014-05-30 8:56 ` Michael Ellerman
@ 2014-05-30 9:10 ` Michael Neuling
2014-05-30 9:13 ` Alexander Graf
0 siblings, 1 reply; 9+ messages in thread
From: Michael Neuling @ 2014-05-30 9:10 UTC (permalink / raw)
To: Michael Ellerman
Cc: kvm-ppc@vger.kernel.org, Paul Mackerras, linuxppc-dev,
Alexander Graf, kvm@vger.kernel.org
On Fri, 2014-05-30 at 18:56 +1000, Michael Ellerman wrote:
> On Thu, 2014-05-29 at 17:45 +1000, Michael Neuling wrote:
> > > > +/* Values for 2nd argument to H_SET_MODE */
> > > > +#define H_SET_MODE_RESOURCE_SET_CIABR 1
> > > > +#define H_SET_MODE_RESOURCE_SET_DAWR 2
> > > > +#define H_SET_MODE_RESOURCE_ADDR_TRANS_MODE 3
> > > > +#define H_SET_MODE_RESOURCE_LE 4
> > >=20
> > > Much better, but I think you want to make use of these in non-kvm cod=
e too,
> > > no? At least the LE one is definitely already implemented as call :)
> >=20
> > powerpc/pseries: Use new defines when calling h_set_mode
> >=20
> > Now that we define these in the KVM code, use these defines when we cal=
l
> > h_set_mode. No functional change.
> >=20
> > Signed-off-by: Michael Neuling <mikey@neuling.org>
> > --
> > This depends on the KVM h_set_mode patches.
> >=20
> > diff --git a/arch/powerpc/include/asm/plpar_wrappers.h b/arch/powerpc/i=
nclude/asm/plpar_wrappers.h
> > index 12c32c5..67859ed 100644
> > --- a/arch/powerpc/include/asm/plpar_wrappers.h
> > +++ b/arch/powerpc/include/asm/plpar_wrappers.h
> > @@ -273,7 +273,7 @@ static inline long plpar_set_mode(unsigned long mfl=
ags, unsigned long resource,
> > static inline long enable_reloc_on_exceptions(void)
> > {
> > /* mflags =3D 3: Exceptions at 0xC000000000004000 */
> > - return plpar_set_mode(3, 3, 0, 0);
> > + return plpar_set_mode(3, H_SET_MODE_RESOURCE_ADDR_TRANS_MODE, 0, 0);
> > }
>=20
> Which header are these coming from, and why aren't we including it? And i=
s it
> going to still build with CONFIG_KVM=3Dn?
=46rom include/asm/hvcall.h in the h_set_mode patch set I sent before.
And yes it compiles with CONFIG_KVM=3Dn fine.
Mikey
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: powerpc/pseries: Use new defines when calling h_set_mode
2014-05-30 9:10 ` Michael Neuling
@ 2014-05-30 9:13 ` Alexander Graf
2014-05-30 9:44 ` Michael Neuling
0 siblings, 1 reply; 9+ messages in thread
From: Alexander Graf @ 2014-05-30 9:13 UTC (permalink / raw)
To: Michael Neuling, Michael Ellerman
Cc: Paul Mackerras, linuxppc-dev, kvm-ppc@vger.kernel.org,
kvm@vger.kernel.org
On 30.05.14 11:10, Michael Neuling wrote:
> On Fri, 2014-05-30 at 18:56 +1000, Michael Ellerman wrote:
>> On Thu, 2014-05-29 at 17:45 +1000, Michael Neuling wrote:
>>>>> +/* Values for 2nd argument to H_SET_MODE */
>>>>> +#define H_SET_MODE_RESOURCE_SET_CIABR 1
>>>>> +#define H_SET_MODE_RESOURCE_SET_DAWR 2
>>>>> +#define H_SET_MODE_RESOURCE_ADDR_TRANS_MODE 3
>>>>> +#define H_SET_MODE_RESOURCE_LE 4
>>>> Much better, but I think you want to make use of these in non-kvm code too,
>>>> no? At least the LE one is definitely already implemented as call :)
>>> powerpc/pseries: Use new defines when calling h_set_mode
>>>
>>> Now that we define these in the KVM code, use these defines when we call
>>> h_set_mode. No functional change.
>>>
>>> Signed-off-by: Michael Neuling <mikey@neuling.org>
>>> --
>>> This depends on the KVM h_set_mode patches.
>>>
>>> diff --git a/arch/powerpc/include/asm/plpar_wrappers.h b/arch/powerpc/include/asm/plpar_wrappers.h
>>> index 12c32c5..67859ed 100644
>>> --- a/arch/powerpc/include/asm/plpar_wrappers.h
>>> +++ b/arch/powerpc/include/asm/plpar_wrappers.h
>>> @@ -273,7 +273,7 @@ static inline long plpar_set_mode(unsigned long mflags, unsigned long resource,
>>> static inline long enable_reloc_on_exceptions(void)
>>> {
>>> /* mflags = 3: Exceptions at 0xC000000000004000 */
>>> - return plpar_set_mode(3, 3, 0, 0);
>>> + return plpar_set_mode(3, H_SET_MODE_RESOURCE_ADDR_TRANS_MODE, 0, 0);
>>> }
>> Which header are these coming from, and why aren't we including it? And is it
>> going to still build with CONFIG_KVM=n?
> From include/asm/hvcall.h in the h_set_mode patch set I sent before.
>
> And yes it compiles with CONFIG_KVM=n fine.
Please split that patch into one that adds the definitions and one that
changes the KVM code to use those definitions. Both Ben and me can then
apply the definition patch and our respective tree patch.
Alex
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: powerpc/pseries: Use new defines when calling h_set_mode
2014-05-30 9:13 ` Alexander Graf
@ 2014-05-30 9:44 ` Michael Neuling
2014-05-30 9:44 ` Alexander Graf
0 siblings, 1 reply; 9+ messages in thread
From: Michael Neuling @ 2014-05-30 9:44 UTC (permalink / raw)
To: Alexander Graf; +Cc: linuxppc-dev, Paul Mackerras, kvm@vger.kernel.org, kvm-ppc
[-- Attachment #1: Type: text/plain, Size: 667 bytes --]
>>>
>>> Which header are these coming from, and why aren't we including it? And
is it
>>> going to still build with CONFIG_KVM=n?
>>
>> From include/asm/hvcall.h in the h_set_mode patch set I sent before.
>>
>> And yes it compiles with CONFIG_KVM=n fine.
>
>
> Please split that patch into one that adds the definitions and one that
changes the KVM code to use those definitions. Both Ben and me can then
apply the definition patch and our respective tree patch.
>
Why don't you just take the original h_set_mode patch and I'll repost this
cleanup later to ben when yours is upstream. This cleanup patch is not
critical to anything and it avoid more churn.
Mikey
[-- Attachment #2: Type: text/html, Size: 852 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: powerpc/pseries: Use new defines when calling h_set_mode
2014-05-30 9:44 ` Michael Neuling
@ 2014-05-30 9:44 ` Alexander Graf
0 siblings, 0 replies; 9+ messages in thread
From: Alexander Graf @ 2014-05-30 9:44 UTC (permalink / raw)
To: Michael Neuling
Cc: linuxppc-dev, Paul Mackerras, kvm@vger.kernel.org, kvm-ppc
On 30.05.14 11:44, Michael Neuling wrote:
>
>
> >>>
> >>> Which header are these coming from, and why aren't we including
> it? And is it
> >>> going to still build with CONFIG_KVM=n?
> >>
> >> From include/asm/hvcall.h in the h_set_mode patch set I sent before.
> >>
> >> And yes it compiles with CONFIG_KVM=n fine.
> >
> >
> > Please split that patch into one that adds the definitions and one
> that changes the KVM code to use those definitions. Both Ben and me
> can then apply the definition patch and our respective tree patch.
> >
>
> Why don't you just take the original h_set_mode patch and I'll repost
> this cleanup later to ben when yours is upstream. This cleanup patch
> is not critical to anything and it avoid more churn.
>
That works too, but please keep in mind that my path to upstream is much
longer than what you're used to ;).
Alex
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2014-05-30 9:44 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1401106626-13130-1-git-send-email-paulus@samba.org>
[not found] ` <1401106626-13130-4-git-send-email-paulus@samba.org>
[not found] ` <5385E620.5090703@suse.de>
[not found] ` <1401342462.4116.4.camel@ale.ozlabs.ibm.com>
[not found] ` <1401344549.4116.8.camel@ale.ozlabs.ibm.com>
[not found] ` <BD1CF085-FEBC-4208-AD3F-C55DB002097F@suse.de>
2014-05-29 7:45 ` powerpc/pseries: Use new defines when calling h_set_mode Michael Neuling
2014-05-29 21:27 ` Alexander Graf
2014-05-29 21:52 ` Benjamin Herrenschmidt
2014-05-30 7:44 ` Alexander Graf
2014-05-30 8:56 ` Michael Ellerman
2014-05-30 9:10 ` Michael Neuling
2014-05-30 9:13 ` Alexander Graf
2014-05-30 9:44 ` Michael Neuling
2014-05-30 9:44 ` Alexander Graf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).