From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4D0291A0239 for ; Thu, 5 Jun 2014 22:32:50 +1000 (EST) Message-ID: <5390636D.2090809@suse.de> Date: Thu, 05 Jun 2014 14:32:45 +0200 From: Alexander Graf MIME-Version: 1.0 To: Benjamin Herrenschmidt Subject: Re: [PATCH 3/3] PPC: KVM: Add support for 64bit TCE windows References: <1401953144-19186-1-git-send-email-aik@ozlabs.ru> <1401953144-19186-4-git-send-email-aik@ozlabs.ru> <1401953908.3247.121.camel@pasglop> <539037DB.5080706@ozlabs.ru> <1401964037.3247.129.camel@pasglop> <53905ADB.8000100@suse.de> <1401971411.3247.132.camel@pasglop> In-Reply-To: <1401971411.3247.132.camel@pasglop> Content-Type: text/plain; charset=UTF-8; format=flowed Cc: kvm@vger.kernel.org, Alexey Kardashevskiy , linux-kernel@vger.kernel.org, kvm-ppc@vger.kernel.org, Gleb Natapov , Paul Mackerras , Paolo Bonzini , linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 05.06.14 14:30, Benjamin Herrenschmidt wrote: > On Thu, 2014-06-05 at 13:56 +0200, Alexander Graf wrote: >> What if we ask user space to give us a pointer to user space allocated >> memory along with the TCE registration? We would still ask user space to >> only use the returned fd for TCE modifications, but would have some >> nicely swappable memory we can store the TCE entries in. > That isn't going to work terribly well for VFIO :-) But yes, for > emulated devices, we could improve things a bit, including for > the 32-bit TCE tables. > > For emulated, the real mode path could walk the page tables and fallback > to virtual mode & get_user if the page isn't present, thus operating > directly on qemu memory TCE tables instead of the current pinned stuff. > > However that has a cost in performance, but since that's really only > used for emulated devices and PAPR VIOs, it might not be a huge issue. > > But for VFIO we don't have much choice, we need to create something the > HW can access. But we need to create separate tables for VFIO anyways, because these TCE tables contain virtual addresses, no? Alex > >> In fact, the code as is today can allocate an arbitrary amount of pinned >> kernel memory from within user space without any checks. > Right. We should at least account it in the locked limit. > > Cheers, > Ben. > >