From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from metis.ext.pengutronix.de (unknown [IPv6:2001:6f8:1178:4:290:27ff:fe1d:cc33]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 1B8881A001C for ; Mon, 23 Jun 2014 17:18:03 +1000 (EST) Message-ID: <53A7D497.7080806@pengutronix.de> Date: Mon, 23 Jun 2014 09:17:43 +0200 From: Marc Kleine-Budde MIME-Version: 1.0 To: Zhao Qiang , linuxppc-dev@lists.ozlabs.org, linux-can@vger.kernel.org, wg@grandegger.com, B07421@freescale.com Subject: Re: [PATCH v3 1/2] flexcan: add err_irq handler for flexcan References: <1403507484-46547-1-git-send-email-B45475@freescale.com> In-Reply-To: <1403507484-46547-1-git-send-email-B45475@freescale.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="VwKANIDswCNP4sgfF0iBKtq7p1UulWGcl" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --VwKANIDswCNP4sgfF0iBKtq7p1UulWGcl Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/23/2014 09:11 AM, Zhao Qiang wrote: > when flexcan is not physically linked, command 'cantest' will > trigger an err_irq, add err_irq handler for it. >=20 > Signed-off-by: Zhao Qiang > --- > Changes for v2: > - use a space instead of tab > - use flexcan_poll_state instead of print > Changes for v3: > - return IRQ_HANDLED if err is triggered > - stop transmitted packets when there is an err_interrupt=20 >=20 > drivers/net/can/flexcan.c | 35 ++++++++++++++++++++++++++++++++++- > 1 file changed, 34 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c > index f425ec2..6802a25 100644 > --- a/drivers/net/can/flexcan.c > +++ b/drivers/net/can/flexcan.c > @@ -208,6 +208,7 @@ struct flexcan_priv { > void __iomem *base; > u32 reg_esr; > u32 reg_ctrl_default; > + unsigned int err_irq; > =20 > struct clk *clk_ipg; > struct clk *clk_per; > @@ -744,6 +745,24 @@ static irqreturn_t flexcan_irq(int irq, void *dev_= id) > return IRQ_HANDLED; > } > =20 > +static irqreturn_t flexcan_err_irq(int irq, void *dev_id) > +{ > + struct net_device *dev =3D dev_id; > + struct flexcan_priv *priv =3D netdev_priv(dev); > + struct flexcan_regs __iomem *regs =3D priv->base; > + u32 reg_ctrl, reg_esr; > + > + reg_esr =3D flexcan_read(®s->esr); > + reg_ctrl =3D flexcan_read(®s->ctrl); > + if (reg_esr & FLEXCAN_ESR_TX_WRN) { When does the hardware trigger the interrupt? > + flexcan_write(reg_esr & ~FLEXCAN_ESR_TX_WRN, ®s->esr); > + flexcan_write(reg_ctrl & ~FLEXCAN_CTRL_ERR_MSK, ®s->ctrl); > + netif_stop_queue(dev); Why are you stopping the txqueue? > + return IRQ_HANDLED; > + } > + return IRQ_NONE; > +} > + Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | --VwKANIDswCNP4sgfF0iBKtq7p1UulWGcl Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iEYEARECAAYFAlOn1JcACgkQjTAFq1RaXHOXqACdGiFYP77jm6Icc1lq+0Nqdxvr EdsAnirWAeoICTFxVv18kkY5U+xjsiWT =F9Dj -----END PGP SIGNATURE----- --VwKANIDswCNP4sgfF0iBKtq7p1UulWGcl--