From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Zhao Qiang <B45475@freescale.com>,
linuxppc-dev@lists.ozlabs.org, wg@grandegger.com,
linux-can@vger.kernel.org, B07421@freescale.com
Subject: Re: [PATCH v5] flexcan: add err_irq handler for flexcan
Date: Thu, 03 Jul 2014 11:14:56 +0200 [thread overview]
Message-ID: <53B51F10.4040900@pengutronix.de> (raw)
In-Reply-To: <1404354180-46431-1-git-send-email-B45475@freescale.com>
[-- Attachment #1: Type: text/plain, Size: 1081 bytes --]
On 07/03/2014 04:23 AM, Zhao Qiang wrote:
> when flexcan is not physically linked, command 'cantest' will
> trigger an err_irq, add err_irq handler for it.
>
> Signed-off-by: Zhao Qiang <B45475@freescale.com>
> ---
> Changes for v2:
> - use a space instead of tab
> - use flexcan_poll_state instead of print
> Changes for v3:
> - return IRQ_HANDLED if err is triggered
> - stop transmitted packets when there is an err_interrupt
> Changes for v4:
> - call flexcan_irq
> Changes for v5:
> - move err_int_handling code from flexcan_irq to flexcan_err_irq
> - call flexcan_err_irq from flexcan_irq
Why do you move the RX IRQ handling into the error IRQ function? If I
understand you correctly you only want to do error interrupt handling
the error IRQ function, right?
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 242 bytes --]
prev parent reply other threads:[~2014-07-03 9:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-03 2:23 [PATCH v5] flexcan: add err_irq handler for flexcan Zhao Qiang
2014-07-03 9:14 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B51F10.4040900@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=B07421@freescale.com \
--cc=B45475@freescale.com \
--cc=linux-can@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).