From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux@roeck-us.net>
Received: from mail.active-venture.com (mail.active-venture.com
 [67.228.131.205])
 by lists.ozlabs.org (Postfix) with ESMTP id B0A3F1A000A
 for <linuxppc-dev@lists.ozlabs.org>; Mon,  7 Jul 2014 22:59:34 +1000 (EST)
Message-ID: <53BA99B3.7050605@roeck-us.net>
Date: Mon, 07 Jul 2014 05:59:31 -0700
From: Guenter Roeck <linux@roeck-us.net>
MIME-Version: 1.0
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: [PATCH v4] powerpc/powernv: hwmon driver for power, fan rpm,
 voltage and temperature
References: <20140704105343.22437.52125.stgit@localhost.localdomain>	
 <53B76220.9090900@roeck-us.net> <1404716172.16156.8.camel@pasglop>
In-Reply-To: <1404716172.16156.8.camel@pasglop>
Content-Type: text/plain; charset=UTF-8; format=flowed
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
 lm-sensors@lm-sensors.org, sbhat@linux.vnet.ibm.com,
 Neelesh Gupta <neelegup@linux.vnet.ibm.com>, linuxppc-dev@lists.ozlabs.org,
 jdelvare@suse.de
List-Id: Linux on PowerPC Developers Mail List <linuxppc-dev.lists.ozlabs.org>
List-Unsubscribe: <https://lists.ozlabs.org/options/linuxppc-dev>,
 <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>
List-Archive: <http://lists.ozlabs.org/pipermail/linuxppc-dev/>
List-Post: <mailto:linuxppc-dev@lists.ozlabs.org>
List-Help: <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>
List-Subscribe: <https://lists.ozlabs.org/listinfo/linuxppc-dev>,
 <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>

On 07/06/2014 11:56 PM, Benjamin Herrenschmidt wrote:
> On Fri, 2014-07-04 at 19:25 -0700, Guenter Roeck wrote:
>>> +cooling-fan#8-data {
>>> +     sensor-id = <0x7052107>;
>>> +     phandle = <0x10000028>;
>>> +     linux,phandle = <0x10000028>;
>>> +     compatible = "ibm,opal-sensor-cooling-fan";
>>
>> phandle and linux-phandle are neither documented nor used. Either
>> document or drop.
>
> They are core device-tree stuff, as such they are used potentially
> anywhere and afaik can be / are generated by DTC but yes, this is
> not the place to document them.
>

Turns out they are documented elsewhere. See
Documentation/devicetree/booting-without-of.txt.

> Or rather, "phandle" is, "linux,phandle" is an older variant used
> for backward compatibility that our firmware still generates but
> definitely something we can strip from the doc.
>

Both are not mentioned in any other bindings, so my take is they should
not be mentioned here either.

Thanks,
Guenter