From: Varka Bhadram <varkabhadram@gmail.com>
To: Nicolin Chen <Guangyu.Chen@freescale.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
alsa-devel@alsa-project.org, b42378@freescale.com,
timur@tabi.org, pawel.moll@arm.com,
ijc+devicetree@hellion.org.uk, tiwai@suse.de,
linux-kernel@vger.kernel.org, rdunlap@infradead.org,
b02247@freescale.com, lgirdwood@gmail.com, robh+dt@kernel.org,
perex@perex.cz, Nicolin Chen <nicoleotsuka@gmail.com>,
broonie@kernel.org, galak@codeaurora.org,
grant.likely@linaro.org, tklauser@distanz.ch,
shawn.guo@linaro.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v4 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers
Date: Fri, 25 Jul 2014 14:13:10 +0530 [thread overview]
Message-ID: <53D2189E.4030108@gmail.com> (raw)
In-Reply-To: <20140725075755.GA29564@MrMyself>
On 07/25/2014 01:27 PM, Nicolin Chen wrote:
> Hi Varka,
>
> Thank you for the comments!
>
> On Fri, Jul 25, 2014 at 01:05:05PM +0530, Varka Bhadram wrote:
>> On 07/25/2014 12:49 PM, Nicolin Chen wrote:
>> (...)
>>
>>> +static const struct platform_device_id fsl_asrc_devtype[] = {
>>> + {
>>> + .name = "imx35-asrc",
>>> + .driver_data = IMX35_ASRC,
>>> + }, {
>>> + .name = "imx53-asrc",
>>> + .driver_data = IMX53_ASRC,
>>> + }, {
>>> + /* sentinel */
>>> + }
>>> +};
>>> +MODULE_DEVICE_TABLE(platform, fsl_asrc_devtype);
>>> +
>> where are you using fsl_asrc_devtype,,,?
>>
>>> +static const struct of_device_id fsl_asrc_ids[] = {
>>> + {
>>> + .compatible = "fsl,imx35-asrc",
>>> + .data = &fsl_asrc_devtype[IMX35_ASRC],
>> Ya here ... but what is the use...?
> I got your point. I will drop all these and move ids behind probe/remove()
> as you suggested at the first place and then use of_device_is_compatible()
> inside the probe() instead.
>
>>> + asrc_priv->regmap = devm_regmap_init_mmio_clk(&pdev->dev,
>>> + "mem", regs, &fsl_asrc_regmap_config);
>> devm_regmap_init_mmio_clk(&pdev->dev,
>> "mem", regs,
>> &fsl_asrc_regmap_config);
> I'll refine to
>
> devm_regmap_init_mmio_clk(&pdev->dev, "mem", regs,
> &fsl_asrc_regmap_config);
>
>>> + if (IS_ERR(asrc_priv->regmap)) {
>>> + dev_err(&pdev->dev, "failed to init regmap\n");
>>> + return PTR_ERR(asrc_priv->regmap);
>>> + }
>>> +
>>> + irq = platform_get_irq(pdev, 0);
>>> + if (irq < 0) {
>>> + dev_err(&pdev->dev, "no irq for node %s\n", np->full_name);
>>> + return irq;
>>> + }
>>> +
>>> + ret = devm_request_irq(&pdev->dev, irq, fsl_asrc_isr, 0,
>>> + asrc_priv->name, asrc_priv);
>> same...
> Sorry I don't see any problem with this devm_request_irq()...
Ohhh... This is the problem with my email client... Sorry...
Thanks...
--
Regards,
Varka Bhadram.
next prev parent reply other threads:[~2014-07-25 8:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-25 7:19 [PATCH v4 0/2] Add Freescale ASRC driver Nicolin Chen
2014-07-25 7:19 ` [PATCH v4 1/2] ARM: imx: Add the secondary request into the structure for imx-sdma Nicolin Chen
2014-07-25 7:19 ` [PATCH v4 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers Nicolin Chen
2014-07-25 7:35 ` Varka Bhadram
2014-07-25 7:57 ` Nicolin Chen
2014-07-25 8:43 ` Varka Bhadram [this message]
2014-07-25 8:42 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D2189E.4030108@gmail.com \
--to=varkabhadram@gmail.com \
--cc=Guangyu.Chen@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=b02247@freescale.com \
--cc=b42378@freescale.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mark.rutland@arm.com \
--cc=nicoleotsuka@gmail.com \
--cc=pawel.moll@arm.com \
--cc=perex@perex.cz \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=shawn.guo@linaro.org \
--cc=timur@tabi.org \
--cc=tiwai@suse.de \
--cc=tklauser@distanz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).