From: Vishal Mansur <vmansur@linux.vnet.ibm.com>
To: gwshan@linux.vnet.ibm.com, benh@kernel.crashing.org,
linuxppc-dev@lists.ozlabs.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] powerpc: non-GPL export for eeh_dev_check_failure
Date: Tue, 05 Aug 2014 20:12:09 +0530 [thread overview]
Message-ID: <53E0ED41.8030804@linux.vnet.ibm.com> (raw)
EEH kernel services are inconsistently exported by the
kernel. eeh_check_failure is exported for any use, but
eeh_dev_check_failure is exported only for GPL use.
While eeh_check_failure is implemented for a specific
purpose to be used by services such as readl, it is
not suited for a purpose where caller needs eeh status.
This functionality is provided by eeh_dev_check_failure.
This patch relaxes the export for eeh_dev_check_failure
to make it consistent with eeh_check_failure() and
usable by non-GPL modules.
Signed-off-by: Vishal Mansur <vmansur@linux.vnet.ibm.com>
---
arch/powerpc/kernel/eeh.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/powerpc/kernel/eeh.c b/arch/powerpc/kernel/eeh.c
index 86e2570..8689c30 100644
--- a/arch/powerpc/kernel/eeh.c
+++ b/arch/powerpc/kernel/eeh.c
@@ -496,8 +496,7 @@ dn_unlock:
eeh_serialize_unlock(flags);
return rc;
}
-
-EXPORT_SYMBOL_GPL(eeh_dev_check_failure);
+EXPORT_SYMBOL(eeh_dev_check_failure);
/**
* eeh_check_failure - Check if all 1's data is due to EEH slot freeze
--
2.0.1
next reply other threads:[~2014-08-05 14:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-05 14:42 Vishal Mansur [this message]
2014-08-05 14:51 ` [PATCH] powerpc: non-GPL export for eeh_dev_check_failure One Thousand Gnomes
2014-08-11 3:16 ` Benjamin Herrenschmidt
2014-08-13 7:29 ` Vishal Mansur
-- strict thread matches above, loose matches on Subject: below --
2014-08-05 14:35 Vishal Mansur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E0ED41.8030804@linux.vnet.ibm.com \
--to=vmansur@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=gwshan@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).