From: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: kvm@vger.kernel.org, agraf@suse.de, kvm-ppc@vger.kernel.org,
paulus@samba.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v3] powerpc/kvm: support to handle sw breakpoint
Date: Mon, 11 Aug 2014 09:29:59 +0530 [thread overview]
Message-ID: <53E83FBF.2040607@linux.vnet.ibm.com> (raw)
In-Reply-To: <20140803155108.GA19710@gate.crashing.org>
On Sunday 03 August 2014 09:21 PM, Segher Boessenkool wrote:
>> +/*
>> + * KVMPPC_INST_BOOK3S_DEBUG is debug Instruction for supporting Software Breakpoint.
>> + * Based on PowerISA v2.07, Instruction with opcode 0s will be treated as illegal
>> + * instruction.
>> + */
>
> "primary opcode 0" instead?
>
ok sure.
>> +#define OP_ZERO 0x0
>
> Using 0x0 where you mean 0, making a #define for 0 in the first place...
> This all looks rather silly doesn't it.
>
I wanted to avoid zero mentioned in the case statement, but can add a
comment explaining it.
>> + case OP_ZERO:
>> + if((inst & 0x00FFFF00) == KVMPPC_INST_BOOK3S_DEBUG) {
>
> You either shouldn't mask at all here, or the mask is wrong (the primary
> op is the top six bits, not the top eight).
>
Yes. I guess I dont need to check here. Will resend the patch.
Thanks for review
Regards
Maddy
>
> Segher
>
next prev parent reply other threads:[~2014-08-11 4:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-01 4:50 [PATCH v3] powerpc/kvm: support to handle sw breakpoint Madhavan Srinivasan
2014-08-03 15:51 ` Segher Boessenkool
2014-08-11 3:59 ` Madhavan Srinivasan [this message]
2014-08-11 7:26 ` Alexander Graf
2014-08-11 8:51 ` Benjamin Herrenschmidt
2014-08-11 9:15 ` Alexander Graf
2014-08-12 5:17 ` Madhavan Srinivasan
2014-08-12 11:19 ` Alexander Graf
2014-08-12 11:35 ` Madhavan Srinivasan
2014-08-12 12:15 ` Alexander Graf
2014-08-12 12:21 ` Madhavan Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E83FBF.2040607@linux.vnet.ibm.com \
--to=maddy@linux.vnet.ibm.com \
--cc=agraf@suse.de \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).