From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f45.google.com (mail-pa0-f45.google.com [209.85.220.45]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id A36D21A0625 for ; Fri, 15 Aug 2014 13:00:56 +1000 (EST) Received: by mail-pa0-f45.google.com with SMTP id eu11so2745630pac.18 for ; Thu, 14 Aug 2014 20:00:54 -0700 (PDT) Message-ID: <53ED77DB.8010103@ozlabs.ru> Date: Fri, 15 Aug 2014 13:00:43 +1000 From: Alexey Kardashevskiy MIME-Version: 1.0 To: Alexander Graf , "Aneesh Kumar K.V" , linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v2] PC, KVM, CMA: Fix regression caused by wrong get_order() use References: <1407992587-9164-1-git-send-email-aik@ozlabs.ru> <87egwj64bz.fsf@linux.vnet.ibm.com> <53ECBC6B.5030507@suse.de> In-Reply-To: <53ECBC6B.5030507@suse.de> Content-Type: text/plain; charset=koi8-r Cc: kvm@vger.kernel.org, Gleb Natapov , linux-kernel@vger.kernel.org, kvm-ppc@vger.kernel.org, Paul Mackerras , Paolo Bonzini , Joonsoo Kim List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 08/14/2014 11:40 PM, Alexander Graf wrote: > > On 14.08.14 07:13, Aneesh Kumar K.V wrote: >> Alexey Kardashevskiy writes: >> >>> fc95ca7284bc54953165cba76c3228bd2cdb9591 claims that there is no >>> functional change but this is not true as it calls get_order() (which >>> takes bytes) where it should have called ilog2() and the kernel stops >>> on VM_BUG_ON(). >>> >>> This replaces get_order() with order_base_2() (round-up version of ilog2). >>> >>> Suggested-by: Paul Mackerras >>> Cc: Alexander Graf >>> Cc: Aneesh Kumar K.V >>> Cc: Joonsoo Kim >>> Cc: Benjamin Herrenschmidt >>> Signed-off-by: Alexey Kardashevskiy >> Reviewed-by: Aneesh Kumar K.V > > So this affects 3.17? Yes. -- Alexey