From: Mike Qiu <qiudayu@linux.vnet.ibm.com>
To: Mike Qiu <qiudayu@linux.vnet.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org, gwshan@linux.vnet.ibm.com
Subject: Re: [PATCH] powerpc/powernv: Avoid to set EEH_PE_ISOLATED for passed PE
Date: Fri, 15 Aug 2014 11:17:45 +0800 [thread overview]
Message-ID: <53ED7BD9.4060906@linux.vnet.ibm.com> (raw)
In-Reply-To: <1407928458-8125-1-git-send-email-qiudayu@linux.vnet.ibm.com>
Hi, all
After discussing with Gavin offline, it's inappropriate to drop ISOLATED
state. Please ignore this patch.
Otherwise, somebody will merge that to mainline, which would be a problem.
Thanks,
Mike
On 08/13/2014 07:14 PM, Mike Qiu wrote:
> When PE passed to guest, and guest EEH occured with this PE,
> EEH_PE_ISOLATED maybe set in host.
>
> It is a big issue when the PE is reused by host, host EEH
> will not work on this PE because it was set to EEH_PE_ISOLATED
> unexpectly.
>
> Signed-off-by: Mike Qiu <qiudayu@linux.vnet.ibm.com>
> ---
> arch/powerpc/platforms/powernv/eeh-ioda.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/platforms/powernv/eeh-ioda.c b/arch/powerpc/platforms/powernv/eeh-ioda.c
> index c945bed..e88eaf6 100644
> --- a/arch/powerpc/platforms/powernv/eeh-ioda.c
> +++ b/arch/powerpc/platforms/powernv/eeh-ioda.c
> @@ -371,7 +371,8 @@ static int ioda_eeh_get_pe_state(struct eeh_pe *pe)
> !(result & EEH_STATE_UNAVAILABLE) &&
> !(result & EEH_STATE_MMIO_ACTIVE) &&
> !(result & EEH_STATE_DMA_ACTIVE) &&
> - !(pe->state & EEH_PE_ISOLATED)) {
> + !(pe->state & EEH_PE_ISOLATED) &&
> + !eeh_pe_passed(pe)) {
> if (phb->freeze_pe)
> phb->freeze_pe(phb, pe->addr);
>
prev parent reply other threads:[~2014-08-15 3:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-13 11:14 [PATCH] powerpc/powernv: Avoid to set EEH_PE_ISOLATED for passed PE Mike Qiu
2014-08-15 3:17 ` Mike Qiu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53ED7BD9.4060906@linux.vnet.ibm.com \
--to=qiudayu@linux.vnet.ibm.com \
--cc=gwshan@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).