* [PATCH] powerpc/powernv: Avoid to set EEH_PE_ISOLATED for passed PE
@ 2014-08-13 11:14 Mike Qiu
2014-08-15 3:17 ` Mike Qiu
0 siblings, 1 reply; 2+ messages in thread
From: Mike Qiu @ 2014-08-13 11:14 UTC (permalink / raw)
To: linuxppc-dev; +Cc: Mike Qiu, gwshan
When PE passed to guest, and guest EEH occured with this PE,
EEH_PE_ISOLATED maybe set in host.
It is a big issue when the PE is reused by host, host EEH
will not work on this PE because it was set to EEH_PE_ISOLATED
unexpectly.
Signed-off-by: Mike Qiu <qiudayu@linux.vnet.ibm.com>
---
arch/powerpc/platforms/powernv/eeh-ioda.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/powernv/eeh-ioda.c b/arch/powerpc/platforms/powernv/eeh-ioda.c
index c945bed..e88eaf6 100644
--- a/arch/powerpc/platforms/powernv/eeh-ioda.c
+++ b/arch/powerpc/platforms/powernv/eeh-ioda.c
@@ -371,7 +371,8 @@ static int ioda_eeh_get_pe_state(struct eeh_pe *pe)
!(result & EEH_STATE_UNAVAILABLE) &&
!(result & EEH_STATE_MMIO_ACTIVE) &&
!(result & EEH_STATE_DMA_ACTIVE) &&
- !(pe->state & EEH_PE_ISOLATED)) {
+ !(pe->state & EEH_PE_ISOLATED) &&
+ !eeh_pe_passed(pe)) {
if (phb->freeze_pe)
phb->freeze_pe(phb, pe->addr);
--
1.8.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] powerpc/powernv: Avoid to set EEH_PE_ISOLATED for passed PE
2014-08-13 11:14 [PATCH] powerpc/powernv: Avoid to set EEH_PE_ISOLATED for passed PE Mike Qiu
@ 2014-08-15 3:17 ` Mike Qiu
0 siblings, 0 replies; 2+ messages in thread
From: Mike Qiu @ 2014-08-15 3:17 UTC (permalink / raw)
To: Mike Qiu; +Cc: linuxppc-dev, gwshan
Hi, all
After discussing with Gavin offline, it's inappropriate to drop ISOLATED
state. Please ignore this patch.
Otherwise, somebody will merge that to mainline, which would be a problem.
Thanks,
Mike
On 08/13/2014 07:14 PM, Mike Qiu wrote:
> When PE passed to guest, and guest EEH occured with this PE,
> EEH_PE_ISOLATED maybe set in host.
>
> It is a big issue when the PE is reused by host, host EEH
> will not work on this PE because it was set to EEH_PE_ISOLATED
> unexpectly.
>
> Signed-off-by: Mike Qiu <qiudayu@linux.vnet.ibm.com>
> ---
> arch/powerpc/platforms/powernv/eeh-ioda.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/platforms/powernv/eeh-ioda.c b/arch/powerpc/platforms/powernv/eeh-ioda.c
> index c945bed..e88eaf6 100644
> --- a/arch/powerpc/platforms/powernv/eeh-ioda.c
> +++ b/arch/powerpc/platforms/powernv/eeh-ioda.c
> @@ -371,7 +371,8 @@ static int ioda_eeh_get_pe_state(struct eeh_pe *pe)
> !(result & EEH_STATE_UNAVAILABLE) &&
> !(result & EEH_STATE_MMIO_ACTIVE) &&
> !(result & EEH_STATE_DMA_ACTIVE) &&
> - !(pe->state & EEH_PE_ISOLATED)) {
> + !(pe->state & EEH_PE_ISOLATED) &&
> + !eeh_pe_passed(pe)) {
> if (phb->freeze_pe)
> phb->freeze_pe(phb, pe->addr);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-08-15 3:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-13 11:14 [PATCH] powerpc/powernv: Avoid to set EEH_PE_ISOLATED for passed PE Mike Qiu
2014-08-15 3:17 ` Mike Qiu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).