From: Lars-Peter Clausen <lars@metafoo.de>
To: Shengjiu Wang <shengjiu.wang@freescale.com>,
lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz,
tiwai@suse.de, nicoleotsuka@gmail.com, Li.Xiubo@freescale.com,
shc_work@mail.ru, fabio.estevam@freescale.com, xobs@kosagi.com,
arnd@arndb.de, sfr@canb.auug.org.au, timur@tabi.org
Cc: alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [alsa-devel] [PATCH V1 1/3] ASoC: fsl: Kconfig: remove dependence of SND_IMX_SOC for SND_SOC_IMX_PCM_DMA
Date: Mon, 18 Aug 2014 18:52:46 +0200 [thread overview]
Message-ID: <53F22F5E.2090601@metafoo.de> (raw)
In-Reply-To: <f30ba4e2c4eb6702fa40bd255036e6e9ad6eb47d.1408350626.git.shengjiu.wang@freescale.com>
On 08/18/2014 10:38 AM, Shengjiu Wang wrote:
> Build kernel with SND_SOC_IMC_PCM_DMA=m && SND_IMX_SOC=n leads the following
> error:
>
> sound/built-in.o: In function `fsl_sai_probe':
>>> fsl_sai.c:(.text+0x5f662): undefined reference to `imx_pcm_dma_init'
> sound/built-in.o: In function `fsl_esai_probe':
>>> fsl_esai.c:(.text+0x6044b): undefined reference to `imx_pcm_dma_init'
>
> Most cpu driver in soc/fsl has use the function 'imx_pcm_dma_init' which is
> defined in imx-pcm-dma.c, so need to select SND_SOC_IMX_PCM_DMA, but it depends
> on SND_IMX_SOC, if SND_IMX_SOC=n, then SND_SOC_IMX_PCM_DMA will not be
> selected.
> So remove the dependence of SND_IMX_SOC for SND_SOC_IMX_PCM_DMA.
>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Shengjiu Wang <shengjiu.wang@freescale.com>
Those if conditions where just added[1] by Arnd to avoid other build
failures. So just removing them again makes little sense.
As far as I can see imx_pcm_dma_init() should be stubbed out when
SND_SOC_IMX_PCM_DMA is not selected. So what's going on here?
[1]
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=ff40260f79dc0436604452bccd449bffd25ebafb
next prev parent reply other threads:[~2014-08-18 17:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-18 8:38 [PATCH V1 0/3] fix build error/warning in sound/soc/fsl Shengjiu Wang
2014-08-18 8:38 ` [PATCH V1 1/3] ASoC: fsl: Kconfig: remove dependence of SND_IMX_SOC for SND_SOC_IMX_PCM_DMA Shengjiu Wang
2014-08-18 16:52 ` Lars-Peter Clausen [this message]
2014-08-19 7:41 ` [alsa-devel] " Shengjiu Wang
2014-08-19 8:13 ` Li.Xiubo
2014-08-19 8:21 ` Shengjiu Wang
2014-08-19 8:31 ` Li.Xiubo
2014-08-19 9:00 ` Li.Xiubo
2014-08-19 9:05 ` shengjiu.wang
2014-08-19 10:35 ` Takashi Iwai
2014-08-19 10:39 ` Lars-Peter Clausen
2014-08-19 8:36 ` Lars-Peter Clausen
2014-08-19 8:45 ` Lars-Peter Clausen
2014-08-19 8:55 ` Shengjiu Wang
2014-08-18 8:38 ` [PATCH V1 2/3] ASoC: fsl-asoc-card: Fix build warning for maybe-uninitialized Shengjiu Wang
2014-08-18 14:53 ` Mark Brown
2014-08-18 8:38 ` [PATCH V1 3/3] ASoC: fsl: fsl-asoc-card: Select SND_SOC_IMX_AUDMUX Shengjiu Wang
2014-08-18 14:54 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F22F5E.2090601@metafoo.de \
--to=lars@metafoo.de \
--cc=Li.Xiubo@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=fabio.estevam@freescale.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nicoleotsuka@gmail.com \
--cc=perex@perex.cz \
--cc=sfr@canb.auug.org.au \
--cc=shc_work@mail.ru \
--cc=shengjiu.wang@freescale.com \
--cc=timur@tabi.org \
--cc=tiwai@suse.de \
--cc=xobs@kosagi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).