From: "Arnd Bergmann" <arnd@arndb.de>
To: "Christophe Leroy" <christophe.leroy@csgroup.eu>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Nicholas Piggin" <npiggin@gmail.com>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc/8xx: Remove init_internal_rtc() to fix no previous prototype error
Date: Thu, 17 Aug 2023 14:43:25 +0200 [thread overview]
Message-ID: <53dc5d0f-8267-480d-a40c-97330e7a290e@app.fastmail.com> (raw)
In-Reply-To: <0aa1141e18a84d926e199093204b37ec993f0c87.1692275185.git.christophe.leroy@csgroup.eu>
On Thu, Aug 17, 2023, at 14:26, Christophe Leroy wrote:
> A W=1 build of mpc885_ads_defconfig throws the following error:
>
> CC arch/powerpc/platforms/8xx/m8xx_setup.o
> arch/powerpc/platforms/8xx/m8xx_setup.c:41:1: error: no previous
> prototype for 'init_internal_rtc' [-Werror=missing-prototypes]
> 41 | init_internal_rtc(void)
> | ^~~~~~~~~~~~~~~~~
>
> init_internal_rtc() was introduced by commit df34403dcaac ("[POWERPC]
> 8xx: Add mpc885ads support and common mpc8xx files") as a weak
> function but has never been defined and/or used outside m8xx_setup.c
>
> As it is called only once there, just fold it into its caller and
> remove it.
>
> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
> Cc: Arnd Bergmann <arnd@arndb.de>
> ---
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
next prev parent reply other threads:[~2023-08-17 12:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-17 12:26 [PATCH] powerpc/8xx: Remove init_internal_rtc() to fix no previous prototype error Christophe Leroy
2023-08-17 12:43 ` Arnd Bergmann [this message]
2023-08-23 11:55 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53dc5d0f-8267-480d-a40c-97330e7a290e@app.fastmail.com \
--to=arnd@arndb.de \
--cc=christophe.leroy@csgroup.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).