From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id DFB541A0037 for ; Wed, 3 Sep 2014 18:34:45 +1000 (EST) Message-ID: <5406D293.3060404@redhat.com> Date: Wed, 03 Sep 2014 10:34:27 +0200 From: Paolo Bonzini MIME-Version: 1.0 To: Laurent Dufour , linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH] powerpc/kvm/cma: Fix panic introduces by signed shift operation References: <1409674381-29465-1-git-send-email-ldufour@linux.vnet.ibm.com> In-Reply-To: <1409674381-29465-1-git-send-email-ldufour@linux.vnet.ibm.com> Content-Type: text/plain; charset=iso-8859-15 Cc: kvm@vger.kernel.org, Alexey Kardashevskiy , Alexander Graf , kvm-ppc@vger.kernel.org, linux-kernel@vger.kernel.org, Paul Mackerras , "Aneesh Kumar K.V" , Joonsoo Kim List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Il 02/09/2014 18:13, Laurent Dufour ha scritto: > fc95ca7284bc54953165cba76c3228bd2cdb9591 introduces a memset in > kvmppc_alloc_hpt since the general CMA doesn't clear the memory it > allocates. > > However, the size argument passed to memset is computed from a signed value > and its signed bit is extended by the cast the compiler is doing. This lead > to extremely large size value when dealing with order value >= 31, and > almost all the memory following the allocated space is cleaned. As a > consequence, the system is panicing and may even fail spawning the kdump > kernel. > > This fix makes use of an unsigned value for the memset's size argument to > avoid sign extension. Among this fix, another shift operation which may > lead to signed extended value too is also fixed. > > Cc: Alexey Kardashevskiy > Cc: Paul Mackerras > Cc: Alexander Graf > Cc: Aneesh Kumar K.V > Cc: Joonsoo Kim > Cc: Benjamin Herrenschmidt > Signed-off-by: Laurent Dufour > --- > arch/powerpc/kvm/book3s_64_mmu_hv.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/powerpc/kvm/book3s_64_mmu_hv.c b/arch/powerpc/kvm/book3s_64_mmu_hv.c > index 72c20bb16d26..79294c4c5015 100644 > --- a/arch/powerpc/kvm/book3s_64_mmu_hv.c > +++ b/arch/powerpc/kvm/book3s_64_mmu_hv.c > @@ -62,10 +62,10 @@ long kvmppc_alloc_hpt(struct kvm *kvm, u32 *htab_orderp) > } > > kvm->arch.hpt_cma_alloc = 0; > - page = kvm_alloc_hpt(1 << (order - PAGE_SHIFT)); > + page = kvm_alloc_hpt(1ul << (order - PAGE_SHIFT)); > if (page) { > hpt = (unsigned long)pfn_to_kaddr(page_to_pfn(page)); > - memset((void *)hpt, 0, (1 << order)); > + memset((void *)hpt, 0, (1ul << order)); > kvm->arch.hpt_cma_alloc = 1; > } > > Thanks, applied to kvm/master. Paolo