From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lb0-f173.google.com (mail-lb0-f173.google.com [209.85.217.173]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 6E2C21A00C7 for ; Fri, 5 Sep 2014 21:41:47 +1000 (EST) Received: by mail-lb0-f173.google.com with SMTP id c11so13316543lbj.32 for ; Fri, 05 Sep 2014 04:41:42 -0700 (PDT) Message-ID: <5409A174.3050205@cogentembedded.com> Date: Fri, 05 Sep 2014 15:41:40 +0400 From: Sergei Shtylyov MIME-Version: 1.0 To: wangyijing Subject: Re: [PATCH v1 15/21] Powerpc/MSI: Use MSI chip framework to configure MSI/MSI-X irq References: <1409911806-10519-1-git-send-email-wangyijing@huawei.com> <1409911806-10519-16-git-send-email-wangyijing@huawei.com> <540994D4.6040500@cogentembedded.com> <43412AE0-85BB-4B4B-A4EA-2C6D3B8B85D7@gmail.com> In-Reply-To: <43412AE0-85BB-4B4B-A4EA-2C6D3B8B85D7@gmail.com> Content-Type: text/plain; charset=gbk; format=flowed Cc: "linux-mips@linux-mips.org" , "linux-ia64@vger.kernel.org" , "linux-pci@vger.kernel.org" , "Bharat.Bhushan@freescale.com" , "sparclinux@vger.kernel.org" , Yijing Wang , "linux-arch@vger.kernel.org" , "linux-s390@vger.kernel.org" , Russell King , Joerg Roedel , "x86@kernel.org" , Sebastian Ott , "xen-devel@lists.xenproject.org" , "arnab.basu@freescale.com" , Arnd Bergmann , Konrad Rzeszutek Wilk , Chris Metcalf , Bjorn Helgaas , Thomas Gleixner , "linux-arm-kernel@lists.infradead.org" , Xinwei Hu , Tony Luck , Ralf Baechle , "iommu@lists.linux-foundation.org" , Wuyun , "linuxppc-dev@lists.ozlabs.org" , "David S. Miller" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 9/5/2014 3:33 PM, wangyijing wrote: >>> Use MSI chip framework instead of arch MSI functions to configure >>> MSI/MSI-X irq. So we can manage MSI/MSI-X irq in a unified framework. >>> Signed-off-by: Yijing Wang >>> --- >>> arch/powerpc/kernel/msi.c | 14 ++++++++++++-- >>> 1 files changed, 12 insertions(+), 2 deletions(-) >>> diff --git a/arch/powerpc/kernel/msi.c b/arch/powerpc/kernel/msi.c >>> index 71bd161..01781a4 100644 >>> --- a/arch/powerpc/kernel/msi.c >>> +++ b/arch/powerpc/kernel/msi.c >> [...] >>> @@ -27,7 +27,17 @@ int arch_setup_msi_irqs(struct pci_dev *dev, int nvec, int type) >>> return ppc_md.setup_msi_irqs(dev, nvec, type); >>> } >>> >>> -void arch_teardown_msi_irqs(struct pci_dev *dev) >>> +static void ppc_teardown_msi_irqs(struct pci_dev *dev) >> Shouldn't this function take IRQ # instead? > This function need to teardown all msi irqs of the pci dev, we should pass the pci dev as argument . Ah, I've mixed up the teardown_irqs() method with teardown_irq()! Too similar. :-) > Thanks! > Yijing. WBR, Sergei