From: Timur Tabi <timur@tabi.org>
To: Mark Brown <broonie@kernel.org>
Cc: Shengjiu Wang <shengjiu.wang@freescale.com>,
alsa-devel@alsa-project.org, tiwai@suse.de,
linux-kernel@vger.kernel.org, lgirdwood@gmail.com,
perex@perex.cz, nicoleotsuka@gmail.com, Li.Xiubo@freescale.com,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH V1] ASoC: fsl_ssi: refine ipg clock usage in this module
Date: Tue, 09 Sep 2014 10:24:00 -0500 [thread overview]
Message-ID: <540F1B90.702@tabi.org> (raw)
In-Reply-To: <20140909152114.GA2601@sirena.org.uk>
On 09/09/2014 10:21 AM, Mark Brown wrote:
>> if (ssi_private->clk)
>> > clk_prepare_enable(ssi_private->clk);
> Should be a !IS_ERR() - NULL is a valid clock.
In that case, ssi_private->clk needs to be initialized to -EINVAL or
something, so that the check works on systems that don't have any clocks.
next prev parent reply other threads:[~2014-09-09 15:24 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 9:18 [PATCH V1] ASoC: fsl_ssi: refine ipg clock usage in this module Shengjiu Wang
2014-09-09 9:49 ` [alsa-devel] " Markus Pargmann
2014-09-09 9:55 ` Li.Xiubo
2014-09-09 11:27 ` Mark Brown
2014-09-09 18:03 ` Nicolin Chen
2014-09-09 18:15 ` Mark Brown
2014-09-09 18:41 ` Nicolin Chen
2014-09-09 13:17 ` Timur Tabi
2014-09-09 15:21 ` Mark Brown
2014-09-09 15:24 ` Timur Tabi [this message]
2014-09-09 18:38 ` Nicolin Chen
2014-09-09 19:37 ` Timur Tabi
2014-09-09 19:59 ` Nicolin Chen
2014-09-09 20:03 ` Timur Tabi
2014-09-09 20:27 ` Nicolin Chen
2014-09-09 20:37 ` Timur Tabi
2014-09-09 21:09 ` Nicolin Chen
2014-09-10 10:01 ` Shengjiu Wang
2014-09-10 6:21 ` Markus Pargmann
2014-09-10 6:42 ` [alsa-devel] " Nicolin Chen
2014-09-10 10:30 ` Shengjiu Wang
2014-09-10 10:53 ` Markus Pargmann
2014-09-10 8:12 ` Shengjiu Wang
2014-09-10 17:42 ` Nicolin Chen
2014-09-11 6:36 ` Markus Pargmann
2014-09-11 7:07 ` Shengjiu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540F1B90.702@tabi.org \
--to=timur@tabi.org \
--cc=Li.Xiubo@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nicoleotsuka@gmail.com \
--cc=perex@perex.cz \
--cc=shengjiu.wang@freescale.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).