From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from szxga02-in.huawei.com (unknown [119.145.14.65]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 6D5EA1A00A1 for ; Thu, 11 Sep 2014 11:30:57 +1000 (EST) Message-ID: <5410FAD9.40702@huawei.com> Date: Thu, 11 Sep 2014 09:28:57 +0800 From: Yijing Wang MIME-Version: 1.0 To: Konrad Rzeszutek Wilk , David Vrabel Subject: Re: [Xen-devel] [PATCH v1 08/21] x86/xen/MSI: Use MSI chip framework to configure MSI/MSI-X irq References: <1409911806-10519-1-git-send-email-wangyijing@huawei.com> <1409911806-10519-9-git-send-email-wangyijing@huawei.com> <5409C8C0.8020200@citrix.com> <540E6095.8030409@huawei.com> <54104641.7020007@citrix.com> <20140910145957.GD12893@laptop.dumpdata.com> In-Reply-To: <20140910145957.GD12893@laptop.dumpdata.com> Content-Type: text/plain; charset="ISO-8859-1" Cc: linux-mips@linux-mips.org, linux-ia64@vger.kernel.org, linux-pci@vger.kernel.org, Xinwei Hu , sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, Russell King , Joerg Roedel , x86@kernel.org, Sebastian Ott , xen-devel@lists.xenproject.org, arnab.basu@freescale.com, Arnd Bergmann , Chris Metcalf , Bjorn Helgaas , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Bharat.Bhushan@freescale.com, Tony Luck , Ralf Baechle , iommu@lists.linux-foundation.org, Wuyun , linuxppc-dev@lists.ozlabs.org, "David S. Miller" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 2014/9/10 22:59, Konrad Rzeszutek Wilk wrote: > On Wed, Sep 10, 2014 at 01:38:25PM +0100, David Vrabel wrote: >> On 09/09/14 03:06, Yijing Wang wrote: >>> On 2014/9/5 22:29, David Vrabel wrote: >>>> On 05/09/14 11:09, Yijing Wang wrote: >>>>> Use MSI chip framework instead of arch MSI functions to configure >>>>> MSI/MSI-X irq. So we can manage MSI/MSI-X irq in a unified framework. >>>> [...] >>>>> --- a/arch/x86/pci/xen.c >>>>> +++ b/arch/x86/pci/xen.c >>>> [...] >>>>> @@ -418,9 +430,9 @@ int __init pci_xen_init(void) >>>>> #endif >>>>> >>>>> #ifdef CONFIG_PCI_MSI >>>>> - x86_msi.setup_msi_irqs = xen_setup_msi_irqs; >>>>> - x86_msi.teardown_msi_irq = xen_teardown_msi_irq; >>>>> - x86_msi.teardown_msi_irqs = xen_teardown_msi_irqs; >>>>> + xen_msi_chip.setup_irqs = xen_setup_msi_irqs; >>>>> + xen_msi_chip.teardown_irqs = xen_teardown_msi_irqs; >>>>> + x86_msi_chip = &xen_msi_chip; >>>>> msi_chip.irq_mask = xen_nop_msi_mask; >>>>> msi_chip.irq_unmask = xen_nop_msi_mask; >>>> >>>> Why have these not been changed to set the x86_msi_chip.mask/unmask >>>> fields instead? >>> >>> Hi David, x86_msi_chip here is struct msi_chip data type, used to configure MSI/MSI-X >>> irq. msi_chip above is struct irq_chip data type, represent the MSI irq controller. They are >>> not the same object. Their name easily confusing people. >> >> Ok, it all makes sense now. >> >> Acked-by: David Vrabel > > You can also add 'Tested-by: Konrad Rzeszutek Wilk ' > > on the whole series - I ran it through on Xen and on baremetal with a mix of 32/64 builds. > > Oh, and also Reviewed-by: Konrad Rzeszutek Wilk the Xen parts. Thanks very much for your test and review! Thanks! Yijing. > >> >> David >> >> _______________________________________________ >> Xen-devel mailing list >> Xen-devel@lists.xen.org >> http://lists.xen.org/xen-devel > > . > -- Thanks! Yijing