From: Milton Miller <miltonm@bga.com>
To: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Cc: linux-ppc <linuxppc-dev@ozlabs.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: [PATCH] 2.6.28-git4 - powerpc - drivers build fails with !CONFIG_VIOPATH
Date: Sun, 4 Jan 2009 02:54:15 -0600 [thread overview]
Message-ID: <5414eaef99b7392a95f6e3488b81dbf7@bga.com> (raw)
In-Reply-To: <20090103191359.GA9304@linux.vnet.ibm.com>
Kamalesh Babulal wrote:
> config SCSI_IBMVSCSI
> tristate "IBM Virtual SCSI support"
> - depends on PPC_PSERIES || PPC_ISERIES
> + depends on (PPC_PSERIES || PPC_ISERIES) && VIOPATH
> select SCSI_SRP_ATTRS
> help
> This is the IBM POWER Virtual SCSI Client
As VIOPATH is iSeries code and is only used by the iSeries code, the
requirment should be
depends on PPC_PSERIES || (PPC_ISERIES && VIOPATH)
except VIOPATH isn't selectable:
arch/powerpc/platforms/iseries/Kconfig:
config VIOPATH
bool
depends on VIODASD || VIOCD || VIOTAPE || ISERIES_VETH
default y
so instead we should be adding
select VIOPATH if PPC_ISERIES
to SCSI_IBMVSCSI and just
select VIOPATH
to HVC_ISERIES as it depends on PPC_ISERIES
otherwise you have to enable one driver to get these other drivers.
milton
next reply other threads:[~2009-01-04 8:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-04 8:54 Milton Miller [this message]
2009-01-04 12:12 ` [PATCH] 2.6.28-git4 - powerpc - drivers build fails with !CONFIG_VIOPATH Stephen Rothwell
2009-01-04 18:24 ` Kamalesh Babulal
2009-01-05 13:33 ` Milton Miller
2009-01-06 7:25 ` Kamalesh Babulal
2009-01-06 7:31 ` Sam Ravnborg
2009-01-06 9:38 ` Kamalesh Babulal
2009-01-06 10:46 ` Sam Ravnborg
2009-01-06 15:57 ` Kamalesh Babulal
2009-01-06 16:40 ` Sam Ravnborg
-- strict thread matches above, loose matches on Subject: below --
2009-01-03 19:13 Kamalesh Babulal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5414eaef99b7392a95f6e3488b81dbf7@bga.com \
--to=miltonm@bga.com \
--cc=kamalesh@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).