From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8CB9C56201 for ; Wed, 25 Nov 2020 16:44:33 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E727A2083E for ; Wed, 25 Nov 2020 16:44:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="ShwHevqz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E727A2083E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4Ch6DZ2t3mzDqxM for ; Thu, 26 Nov 2020 03:44:30 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=198.145.29.99; helo=mail.kernel.org; envelope-from=maz@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=default header.b=ShwHevqz; dkim-atps=neutral Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Ch6BM1d5jzDqwf for ; Thu, 26 Nov 2020 03:42:34 +1100 (AEDT) Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 67B0620857; Wed, 25 Nov 2020 16:42:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606322552; bh=RZad696Dkp864M+XIPKQBVBv1zbGfYkVuN9K54E5zF0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ShwHevqzdywqLdhmN37W0cpnFCJTuDfSWryyONq6Z6etTQwB+RGWNpDP0/cldlFE7 Ig2Tp7Zfr7hKVEgeWj9H+HpEQjyQo5Anum7OMozxG+FD2jUkwwZPO41NOXxsBTiGAw wQkNRWhKuXrafZGHV1afMncS+XD0q0DwZcfQCFGE= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1khxsE-00DZgJ-9e; Wed, 25 Nov 2020 16:42:30 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 25 Nov 2020 16:42:30 +0000 From: Marc Zyngier To: Laurent Vivier Subject: Re: [PATCH v3 2/2] powerpc/pseries: pass MSI affinity to irq_create_mapping() In-Reply-To: <7184880b-0351-ae18-d2e1-fab7b79fc864@redhat.com> References: <20201125150932.1150619-1-lvivier@redhat.com> <20201125150932.1150619-3-lvivier@redhat.com> <7184880b-0351-ae18-d2e1-fab7b79fc864@redhat.com> User-Agent: Roundcube Webmail/1.4.9 Message-ID: <5419d1790c9ea0d9d7791ae887794285@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: lvivier@redhat.com, kda@linux-powerpc.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, hch@lst.de, paulus@samba.org, groug@kaod.org, linuxppc-dev@lists.ozlabs.org, tglx@linutronix.de, benh@kernel.crashing.org, mpe@ellerman.id.au, linux-block@vger.kernel.org, mst@redhat.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Michael S . Tsirkin" , linux-pci@vger.kernel.org, Denis Kirjanov , Greg Kurz , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, Paul Mackerras , Thomas Gleixner , linuxppc-dev@lists.ozlabs.org, Christoph Hellwig Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 2020-11-25 16:24, Laurent Vivier wrote: > On 25/11/2020 17:05, Denis Kirjanov wrote: >> On 11/25/20, Laurent Vivier wrote: >>> With virtio multiqueue, normally each queue IRQ is mapped to a CPU. >>> >>> But since commit 0d9f0a52c8b9f ("virtio_scsi: use virtio IRQ >>> affinity") >>> this is broken on pseries. >> >> Please add "Fixes" tag. > > In fact, the code in commit 0d9f0a52c8b9f is correct. > > The problem is with MSI/X irq affinity and pseries. So this patch > fixes more than virtio_scsi. I put this information because this > commit allows to clearly show the problem. Perhaps I should remove > this line in fact? This patch does not fix virtio_scsi at all, which as you noticed, is correct. It really fixes the PPC MSI setup, which is starting to show its age. So getting rid of the reference seems like the right thing to do. I'm also not keen on the BugId thing. It should really be a lore link. I also cannot find any such tag in the kernel, nor is it a documented practice. The last reference to a Bugzilla entry seems to have happened with 786b5219081ff16 (five years ago). Thanks, M. -- Jazz is not dead. It just smells funny...