From: Yijing Wang <wangyijing@huawei.com>
To: Thomas Gleixner <tglx@linutronix.de>,
Thierry Reding <thierry.reding@gmail.com>
Cc: linux-mips@linux-mips.org, linux-ia64@vger.kernel.org,
linux-pci@vger.kernel.org, Bharat.Bhushan@freescale.com,
sparclinux@vger.kernel.org, linux-arch@vger.kernel.org,
linux-s390@vger.kernel.org, Russell King <linux@arm.linux.org.uk>,
Joerg Roedel <joro@8bytes.org>,
x86@kernel.org, Sebastian Ott <sebott@linux.vnet.ibm.com>,
xen-devel@lists.xenproject.org, arnab.basu@freescale.com,
Arnd Bergmann <arnd@arndb.de>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Chris Metcalf <cmetcalf@tilera.com>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-arm-kernel@lists.infradead.org,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Xinwei Hu <huxinwei@huawei.com>, Tony Luck <tony.luck@intel.com>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
linux-kernel@vger.kernel.org, Ralf Baechle <ralf@linux-mips.org>,
iommu@lists.linux-foundation.org,
David Vrabel <david.vrabel@citrix.com>,
Wuyun <wuyun.wu@huawei.com>,
linuxppc-dev@lists.ozlabs.org,
"David S. Miller" <davem@davemloft.net>,
Lucas Stach <l.stach@pengutronix.de>
Subject: Re: [PATCH v2 01/22] PCI/MSI: Clean up struct msi_chip argument
Date: Fri, 26 Sep 2014 10:15:48 +0800 [thread overview]
Message-ID: <5424CC54.1040507@huawei.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1409251208420.4604@nanos>
On 2014/9/25 18:20, Thomas Gleixner wrote:
> On Thu, 25 Sep 2014, Thierry Reding wrote:
>
>> On Thu, Sep 25, 2014 at 11:14:11AM +0800, Yijing Wang wrote:
>>> Msi_chip functions setup_irq/teardown_irq rarely use msi_chip
>>> argument.
>>
>> That's not true. Out of the four drivers that you modify two use the
>> parameter. And the two that don't probably should be using it too.
>>
>> 50% is not "rarely". =)
>>
>>> We can look up msi_chip pointer by the device pointer
>>> or irq number, so clean up msi_chip argument.
>>
>> I don't like this particular change. The idea was to keep the API object
>> oriented so that drivers wouldn't have to know where to get the MSI chip
>> from. It also makes it more resilient against code reorganizations since
>> the core code is the only place that needs to know where to get the chip
>> from.
>
> Right. We have the same thing in the irq_chip callbacks. All of them
> take "struct irq_data", because it's already available in the core
> code and it gives easy access to all information (chip, chipdata ...)
> which is necessary for the callback implementations.
OK, I will drop this change, tglx, thanks for your review and comments!
Thanks!
Yijing.
>
> Thanks,
>
> tglx
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> .
>
--
Thanks!
Yijing
next prev parent reply other threads:[~2014-09-26 2:16 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-25 3:14 [PATCH v2 00/22] Use MSI chip framework to configure MSI/MSI-X in all platforms Yijing Wang
2014-09-25 3:14 ` [PATCH v2 01/22] PCI/MSI: Clean up struct msi_chip argument Yijing Wang
2014-09-25 7:15 ` Thierry Reding
2014-09-25 10:20 ` Thomas Gleixner
2014-09-26 2:15 ` Yijing Wang [this message]
2014-09-26 1:58 ` Yijing Wang
2014-09-25 3:14 ` [PATCH v2 02/22] PCI/MSI: Remove useless bus->msi assignment Yijing Wang
2014-09-25 7:06 ` Thierry Reding
2014-09-26 1:55 ` Yijing Wang
2014-09-25 3:14 ` [PATCH v2 03/22] MSI: Remove the redundant irq_set_chip_data() Yijing Wang
2014-09-25 7:19 ` Thierry Reding
2014-09-26 2:04 ` Yijing Wang
2014-09-26 8:09 ` Thierry Reding
2014-09-26 8:09 ` Thierry Reding
2014-09-25 3:14 ` [PATCH v2 04/22] x86/xen/MSI: Eliminate arch_msix_mask_irq() and arch_msi_mask_irq() Yijing Wang
2014-09-25 14:33 ` Konrad Rzeszutek Wilk
2014-09-26 3:12 ` Yijing Wang
2014-09-25 3:14 ` [PATCH v2 05/22] s390/MSI: Use __msi_mask_irq() instead of default_msi_mask_irq() Yijing Wang
2014-09-25 3:14 ` [PATCH v2 06/22] PCI/MSI: Introduce weak arch_find_msi_chip() to find MSI chip Yijing Wang
2014-09-25 7:26 ` Thierry Reding
2014-09-26 2:10 ` Yijing Wang
2014-09-25 10:38 ` Thomas Gleixner
2014-09-26 2:33 ` Yijing Wang
2014-09-26 2:44 ` Yijing Wang
2014-09-26 10:38 ` Thomas Gleixner
2014-09-28 2:35 ` Yijing Wang
2014-09-25 3:14 ` [PATCH v2 07/22] PCI/MSI: Refactor struct msi_chip to make it become more common Yijing Wang
2014-09-25 3:14 ` [PATCH v2 08/22] x86/MSI: Use MSI chip framework to configure MSI/MSI-X irq Yijing Wang
2014-09-25 3:14 ` [PATCH v2 09/22] x86/xen/MSI: " Yijing Wang
2014-09-25 3:14 ` [PATCH v2 10/22] Irq_remapping/MSI: " Yijing Wang
2014-09-25 3:14 ` [PATCH v2 11/22] x86/MSI: Remove unused MSI weak arch functions Yijing Wang
2014-09-25 3:14 ` [PATCH v2 12/22] MIPS/Octeon/MSI: Use MSI chip framework to configure MSI/MSI-X irq Yijing Wang
2014-09-25 7:34 ` Thierry Reding
2014-09-26 2:12 ` Yijing Wang
2014-09-25 3:14 ` [PATCH v2 13/22] MIPS/Xlp: Remove the dead function destroy_irq() to fix build error Yijing Wang
2014-09-25 3:14 ` [PATCH v2 14/22] MIPS/Xlp/MSI: Use MSI chip framework to configure MSI/MSI-X irq Yijing Wang
2014-09-25 7:36 ` Thierry Reding
2014-09-26 2:13 ` Yijing Wang
2014-09-25 3:14 ` [PATCH v2 15/22] MIPS/Xlr/MSI: " Yijing Wang
2014-09-25 7:37 ` Thierry Reding
2014-09-26 2:13 ` Yijing Wang
2014-09-25 3:14 ` [PATCH v2 16/22] Powerpc/MSI: " Yijing Wang
2014-09-25 3:14 ` [PATCH v2 17/22] s390/MSI: " Yijing Wang
2014-09-25 7:38 ` Thierry Reding
2014-09-26 2:14 ` Yijing Wang
2014-09-25 3:14 ` [PATCH v2 18/22] arm/iop13xx/MSI: " Yijing Wang
2014-09-25 3:14 ` [PATCH v2 19/22] IA64/MSI: " Yijing Wang
2014-09-25 3:14 ` [PATCH v2 20/22] Sparc/MSI: " Yijing Wang
2014-09-25 3:14 ` [PATCH v2 21/22] tile/MSI: " Yijing Wang
2014-09-25 3:14 ` [PATCH v2 22/22] PCI/MSI: Clean up unused MSI arch functions Yijing Wang
2014-09-25 7:42 ` [PATCH v2 00/22] Use MSI chip framework to configure MSI/MSI-X in all platforms Thierry Reding
2014-09-25 14:48 ` Liviu Dudau
2014-09-25 16:49 ` Thierry Reding
2014-09-25 17:16 ` Liviu Dudau
2014-09-26 6:20 ` Yijing Wang
2014-09-26 8:54 ` Thierry Reding
2014-09-26 9:05 ` Thierry Reding
2014-09-28 2:32 ` Yijing Wang
2014-09-28 6:11 ` Yijing Wang
2014-09-29 8:37 ` Lucas Stach
2014-09-29 10:13 ` Yijing Wang
2014-09-26 3:42 ` Yijing Wang
2014-09-26 8:50 ` Liviu Dudau
2014-09-28 2:16 ` Yijing Wang
2014-09-28 11:21 ` Liviu Dudau
2014-09-29 1:44 ` Yijing Wang
2014-09-29 9:26 ` Liviu Dudau
2014-09-29 10:12 ` Yijing Wang
2014-09-25 14:23 ` Konrad Rzeszutek Wilk
2014-09-26 2:47 ` Yijing Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5424CC54.1040507@huawei.com \
--to=wangyijing@huawei.com \
--cc=Bharat.Bhushan@freescale.com \
--cc=arnab.basu@freescale.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=cmetcalf@tilera.com \
--cc=davem@davemloft.net \
--cc=david.vrabel@citrix.com \
--cc=huxinwei@huawei.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=konrad.wilk@oracle.com \
--cc=l.stach@pengutronix.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=ralf@linux-mips.org \
--cc=sebott@linux.vnet.ibm.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=sparclinux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=tony.luck@intel.com \
--cc=wuyun.wu@huawei.com \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).