From: christophe leroy <christophe.leroy@c-s.fr>
To: Mark Brown <broonie@kernel.org>
Cc: Marcelo Tosatti <marcelo@kvack.org>,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
Paul Mackerras <paulus@samba.org>,
scottwood@freescale.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 2/2] spi: fsl-spi: Allow dynamic allocation of CPM1 parameter RAM
Date: Fri, 03 Oct 2014 22:15:11 +0200 [thread overview]
Message-ID: <542F03CF.8010900@c-s.fr> (raw)
In-Reply-To: <20141003144420.GC24441@sirena.org.uk>
Le 03/10/2014 16:44, Mark Brown a écrit :
> On Fri, Oct 03, 2014 at 02:56:09PM +0200, Christophe Leroy wrote:
>
>> +config CPM1_RELOCSPI
>> + bool "Dynamic SPI relocation"
>> + default n
>> + help
>> + On recent MPC8xx (at least MPC866 and MPC885) SPI can be relocated
>> + without micropatch. This activates relocation to a dynamically
>> + allocated area in the CPM Dual port RAM.
>> + When combined with SPI relocation patch (for older MPC8xx) it avoids
>> + the "loss" of additional Dual port RAM space just above the patch,
>> + which might be needed for example when using the CPM QMC.
> Something like this shouldn't be a compile time option. Either it
> should be unconditional or it should be triggered in some system
> specific manner (from DT, from knowing about other users or similar).
Can't be unconditional as older versions of mpc8xx (eg MPC860) don't
support relocation without a micropatch.
I have therefore submitted a v2 based on a DTS compatible property.
---
Ce courrier électronique ne contient aucun virus ou logiciel malveillant parce que la protection avast! Antivirus est active.
http://www.avast.com
next prev parent reply other threads:[~2014-10-03 20:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-03 12:56 [PATCH 2/2] spi: fsl-spi: Allow dynamic allocation of CPM1 parameter RAM Christophe Leroy
2014-10-03 14:44 ` Mark Brown
2014-10-03 20:15 ` christophe leroy [this message]
2014-10-03 20:24 ` Scott Wood
2014-10-04 10:15 ` christophe leroy
2014-10-07 0:19 ` Scott Wood
2014-10-08 16:46 ` leroy christophe
2014-10-08 18:45 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542F03CF.8010900@c-s.fr \
--to=christophe.leroy@c-s.fr \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=marcelo@kvack.org \
--cc=paulus@samba.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).