linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] powerpc/perf: Fix Power9 test_adder field
@ 2017-05-26  8:08 Madhavan Srinivasan
  2017-05-26 11:22 ` shriyak
  2017-06-08  4:05 ` Michael Ellerman
  0 siblings, 2 replies; 3+ messages in thread
From: Madhavan Srinivasan @ 2017-05-26  8:08 UTC (permalink / raw)
  To: mpe; +Cc: linux-kernel, linuxppc-dev, Madhavan Srinivasan

Commit 8d911904f3ce4 ('powerpc/perf: Add restrictions to PMC5 in power9 DD1')
was added to restrict the use of PMC5 in Power9 DD1. Intend is to diable
the use of PMC5 using raw event code. Commit instead of updating "power9_isa207_pmu"
structure, updated "power9_pmu" structure. Patch to fix the same.

Fixes: 8d911904f3ce4 ('powerpc/perf: Add restrictions to PMC5 in power9 DD1')
Reported-by: Shriya <shriyak@linux.vnet.ibm.com>
Signed-off-by: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
---
 arch/powerpc/perf/power9-pmu.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/powerpc/perf/power9-pmu.c b/arch/powerpc/perf/power9-pmu.c
index 018f8e90ac35..bb28e1a41257 100644
--- a/arch/powerpc/perf/power9-pmu.c
+++ b/arch/powerpc/perf/power9-pmu.c
@@ -402,7 +402,7 @@ static struct power_pmu power9_isa207_pmu = {
 	.name			= "POWER9",
 	.n_counter		= MAX_PMU_COUNTERS,
 	.add_fields		= ISA207_ADD_FIELDS,
-	.test_adder		= ISA207_TEST_ADDER,
+	.test_adder		= P9_DD1_TEST_ADDER,
 	.compute_mmcr		= isa207_compute_mmcr,
 	.config_bhrb		= power9_config_bhrb,
 	.bhrb_filter_map	= power9_bhrb_filter_map,
@@ -421,7 +421,7 @@ static struct power_pmu power9_pmu = {
 	.name			= "POWER9",
 	.n_counter		= MAX_PMU_COUNTERS,
 	.add_fields		= ISA207_ADD_FIELDS,
-	.test_adder		= P9_DD1_TEST_ADDER,
+	.test_adder		= ISA207_TEST_ADDER,
 	.compute_mmcr		= isa207_compute_mmcr,
 	.config_bhrb		= power9_config_bhrb,
 	.bhrb_filter_map	= power9_bhrb_filter_map,
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] powerpc/perf: Fix Power9 test_adder field
  2017-05-26  8:08 [PATCH] powerpc/perf: Fix Power9 test_adder field Madhavan Srinivasan
@ 2017-05-26 11:22 ` shriyak
  2017-06-08  4:05 ` Michael Ellerman
  1 sibling, 0 replies; 3+ messages in thread
From: shriyak @ 2017-05-26 11:22 UTC (permalink / raw)
  To: Madhavan Srinivasan; +Cc: mpe, linuxppc-dev, linux-kernel, Linuxppc-dev

On 2017-05-26 13:38, Madhavan Srinivasan wrote:
> Commit 8d911904f3ce4 ('powerpc/perf: Add restrictions to PMC5 in power9 
> DD1')
> was added to restrict the use of PMC5 in Power9 DD1. Intend is to 
> diable
> the use of PMC5 using raw event code. Commit instead of updating
> "power9_isa207_pmu"
> structure, updated "power9_pmu" structure. Patch to fix the same.
> 
> Fixes: 8d911904f3ce4 ('powerpc/perf: Add restrictions to PMC5 in power9 
> DD1')
> Reported-by: Shriya <shriyak@linux.vnet.ibm.com>
> Signed-off-by: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
> ---
>  arch/powerpc/perf/power9-pmu.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/powerpc/perf/power9-pmu.c 
> b/arch/powerpc/perf/power9-pmu.c
> index 018f8e90ac35..bb28e1a41257 100644
> --- a/arch/powerpc/perf/power9-pmu.c
> +++ b/arch/powerpc/perf/power9-pmu.c
> @@ -402,7 +402,7 @@ static struct power_pmu power9_isa207_pmu = {
>  	.name			= "POWER9",
>  	.n_counter		= MAX_PMU_COUNTERS,
>  	.add_fields		= ISA207_ADD_FIELDS,
> -	.test_adder		= ISA207_TEST_ADDER,
> +	.test_adder		= P9_DD1_TEST_ADDER,
>  	.compute_mmcr		= isa207_compute_mmcr,
>  	.config_bhrb		= power9_config_bhrb,
>  	.bhrb_filter_map	= power9_bhrb_filter_map,
> @@ -421,7 +421,7 @@ static struct power_pmu power9_pmu = {
>  	.name			= "POWER9",
>  	.n_counter		= MAX_PMU_COUNTERS,
>  	.add_fields		= ISA207_ADD_FIELDS,
> -	.test_adder		= P9_DD1_TEST_ADDER,
> +	.test_adder		= ISA207_TEST_ADDER,
>  	.compute_mmcr		= isa207_compute_mmcr,
>  	.config_bhrb		= power9_config_bhrb,
>  	.bhrb_filter_map	= power9_bhrb_filter_map,

Tested-by: Shriya <shriyak@linux.vnet.ibm.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: powerpc/perf: Fix Power9 test_adder field
  2017-05-26  8:08 [PATCH] powerpc/perf: Fix Power9 test_adder field Madhavan Srinivasan
  2017-05-26 11:22 ` shriyak
@ 2017-06-08  4:05 ` Michael Ellerman
  1 sibling, 0 replies; 3+ messages in thread
From: Michael Ellerman @ 2017-06-08  4:05 UTC (permalink / raw)
  To: Madhavan Srinivasan; +Cc: Madhavan Srinivasan, linuxppc-dev, linux-kernel

On Fri, 2017-05-26 at 08:08:27 UTC, Madhavan Srinivasan wrote:
> Commit 8d911904f3ce4 ('powerpc/perf: Add restrictions to PMC5 in power9 DD1')
> was added to restrict the use of PMC5 in Power9 DD1. Intend is to diable
> the use of PMC5 using raw event code. Commit instead of updating "power9_isa207_pmu"
> structure, updated "power9_pmu" structure. Patch to fix the same.
> 
> Fixes: 8d911904f3ce4 ('powerpc/perf: Add restrictions to PMC5 in power9 DD1')
> Reported-by: Shriya <shriyak@linux.vnet.ibm.com>
> Signed-off-by: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
> Tested-by: Shriya <shriyak@linux.vnet.ibm.com>

Applied to powerpc fixes, thanks.

https://git.kernel.org/powerpc/c/8c218578fcbbbdb10416c8614658bf

cheers

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-06-08  4:05 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-26  8:08 [PATCH] powerpc/perf: Fix Power9 test_adder field Madhavan Srinivasan
2017-05-26 11:22 ` shriyak
2017-06-08  4:05 ` Michael Ellerman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).