From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
linux-fbdev@vger.kernel.org, Jingoo Han <jg1.han@samsung.com>,
Daniel Drake <dsd@laptop.org>,
Jens Frederich <jfrederich@gmail.com>,
Jani Nikula <jani.nikula@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jon Nettleton <jon.nettleton@gmail.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
platform-driver-x86@vger.kernel.org,
Lee Jones <lee.jones@linaro.org>,
Randy Dunlap <rdunlap@infradead.org>,
Daniel Vetter <daniel.vetter@intel.com>,
Darren Hart <dvhart@infradead.org>, Bryan Wu <cooloney@gmail.com>,
linuxppc-dev@lists.ozlabs.org,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH] drivers: depend on instead of select BACKLIGHT_CLASS_DEVICE and ACPI_VIDEO
Date: Thu, 23 Oct 2014 14:38:54 +0300 [thread overview]
Message-ID: <5448E8CE.7040405@ti.com> (raw)
In-Reply-To: <20141023081034.GA26941@phenom.ffwll.local>
[-- Attachment #1: Type: text/plain, Size: 857 bytes --]
On 23/10/14 11:10, Daniel Vetter wrote:
> If we want to make BACKLIGHT_CLASS_DEVICE into a library thing then I
> guess we could do that, but we must then also drag it out of all the other
> meta options to make sure it's always available. No need I think to ditch
BACKLIGHT_CLASS_DEVICE only depends on HAS_IOMEM and
BACKLIGHT_LCD_SUPPORT so there are no other meta options to avoid.
HAS_IOMEM comes from drivers/video/Kconfig's "Graphics support", and I
guess we can ignore it.
> the entire BACKLIGHT_LCD_SUPPORT meta option. And then everyone could
> select it.
I don't quite understand what purpose does BACKLIGHT_LCD_SUPPORT serve.
It doesn't enable any code, it just opens up new Kconfig options. Why
can't the Kconfig options be always available? It's just another option
to 'select', without any reason I can see.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-10-23 11:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-17 21:13 [PATCH] drivers: depend on instead of select BACKLIGHT_CLASS_DEVICE and ACPI_VIDEO Jani Nikula
2014-10-21 20:50 ` Darren Hart
2014-10-22 8:02 ` Tomi Valkeinen
2014-10-23 8:10 ` Daniel Vetter
2014-10-23 11:38 ` Tomi Valkeinen [this message]
2014-10-27 11:59 ` Jani Nikula
2014-10-27 13:13 ` Tomi Valkeinen
2014-10-28 20:29 ` Randy Dunlap
2014-10-29 3:04 ` Michael Ellerman
2014-10-29 7:54 ` Jani Nikula
2014-10-29 8:27 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5448E8CE.7040405@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=cooloney@gmail.com \
--cc=daniel.vetter@intel.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=dsd@laptop.org \
--cc=dvhart@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=jani.nikula@intel.com \
--cc=jfrederich@gmail.com \
--cc=jg1.han@samsung.com \
--cc=jon.nettleton@gmail.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lee.jones@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=plagnioj@jcrosoft.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).