From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [103.22.144.67]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id AA4821A00B3 for ; Tue, 4 Nov 2014 02:43:18 +1100 (AEDT) Received: from e06smtp10.uk.ibm.com (e06smtp10.uk.ibm.com [195.75.94.106]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 8DEEC14008C for ; Tue, 4 Nov 2014 02:43:17 +1100 (AEDT) Received: from /spool/local by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 3 Nov 2014 15:43:14 -0000 Message-ID: <5457A306.4040302@linux.vnet.ibm.com> Date: Mon, 03 Nov 2014 16:45:10 +0100 From: Philippe Bergheaud MIME-Version: 1.0 To: Denis Kirjanov Subject: Re: [PATCH] PPC: bpf_jit_comp: add SKF_AD_PKTTYPE instruction References: <1414351406-4122-1-git-send-email-kda@linux-powerpc.org> In-Reply-To: Content-Type: text/plain; charset=us-ascii; format=flowed Cc: linuxppc-dev@ozlabs.org, Matt Evans , netdev@vger.kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Denis Kirjanov wrote: > Any feedback from PPC folks? I have reviewed the patch and it looks fine to me. I have tested successfuly on ppc64le. I could not test it on ppc64. Philippe > On 10/26/14, Denis Kirjanov wrote: > >>Cc: Matt Evans >>Signed-off-by: Denis Kirjanov >>--- >> arch/powerpc/include/asm/ppc-opcode.h | 1 + >> arch/powerpc/net/bpf_jit.h | 7 +++++++ >> arch/powerpc/net/bpf_jit_comp.c | 5 +++++ >> 3 files changed, 13 insertions(+) >> >>diff --git a/arch/powerpc/include/asm/ppc-opcode.h >>b/arch/powerpc/include/asm/ppc-opcode.h >>index 6f85362..1a52877 100644 >>--- a/arch/powerpc/include/asm/ppc-opcode.h >>+++ b/arch/powerpc/include/asm/ppc-opcode.h >>@@ -204,6 +204,7 @@ >> #define PPC_INST_ERATSX_DOT 0x7c000127 >> >> /* Misc instructions for BPF compiler */ >>+#define PPC_INST_LBZ 0x88000000 >> #define PPC_INST_LD 0xe8000000 >> #define PPC_INST_LHZ 0xa0000000 >> #define PPC_INST_LHBRX 0x7c00062c >>diff --git a/arch/powerpc/net/bpf_jit.h b/arch/powerpc/net/bpf_jit.h >>index 9aee27c..c406aa9 100644 >>--- a/arch/powerpc/net/bpf_jit.h >>+++ b/arch/powerpc/net/bpf_jit.h >>@@ -87,6 +87,9 @@ DECLARE_LOAD_FUNC(sk_load_byte_msh); >> #define PPC_STD(r, base, i) EMIT(PPC_INST_STD | ___PPC_RS(r) | \ >> ___PPC_RA(base) | ((i) & 0xfffc)) >> >>+ >>+#define PPC_LBZ(r, base, i) EMIT(PPC_INST_LBZ | ___PPC_RT(r) | \ >>+ ___PPC_RA(base) | IMM_L(i)) >> #define PPC_LD(r, base, i) EMIT(PPC_INST_LD | ___PPC_RT(r) | \ >> ___PPC_RA(base) | IMM_L(i)) >> #define PPC_LWZ(r, base, i) EMIT(PPC_INST_LWZ | ___PPC_RT(r) | \ >>@@ -96,6 +99,10 @@ DECLARE_LOAD_FUNC(sk_load_byte_msh); >> #define PPC_LHBRX(r, base, b) EMIT(PPC_INST_LHBRX | ___PPC_RT(r) | \ >> ___PPC_RA(base) | ___PPC_RB(b)) >> /* Convenience helpers for the above with 'far' offsets: */ >>+#define PPC_LBZ_OFFS(r, base, i) do { if ((i) < 32768) PPC_LBZ(r, base, i); >> \ >>+ else { PPC_ADDIS(r, base, IMM_HA(i)); \ >>+ PPC_LBZ(r, r, IMM_L(i)); } } while(0) >>+ >> #define PPC_LD_OFFS(r, base, i) do { if ((i) < 32768) PPC_LD(r, base, i); >> \ >> else { PPC_ADDIS(r, base, IMM_HA(i)); \ >> PPC_LD(r, r, IMM_L(i)); } } while(0) >>diff --git a/arch/powerpc/net/bpf_jit_comp.c >>b/arch/powerpc/net/bpf_jit_comp.c >>index cbae2df..d110e28 100644 >>--- a/arch/powerpc/net/bpf_jit_comp.c >>+++ b/arch/powerpc/net/bpf_jit_comp.c >>@@ -407,6 +407,11 @@ static int bpf_jit_build_body(struct bpf_prog *fp, u32 >>*image, >> PPC_LHZ_OFFS(r_A, r_skb, offsetof(struct sk_buff, >> queue_mapping)); >> break; >>+ case BPF_ANC | SKF_AD_PKTTYPE: >>+ PPC_LBZ_OFFS(r_A, r_skb, PKT_TYPE_OFFSET()); >>+ PPC_ANDI(r_A, r_A, PKT_TYPE_MAX); >>+ PPC_SRWI(r_A, r_A, 5); >>+ break; >> case BPF_ANC | SKF_AD_CPU: >> #ifdef CONFIG_SMP >> /* >>-- >>2.1.0 >> >> > > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/linuxppc-dev