From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e28smtp06.in.ibm.com (e28smtp06.in.ibm.com [122.248.162.6]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 0D2491A0174 for ; Mon, 17 Nov 2014 17:04:21 +1100 (AEDT) Received: from /spool/local by e28smtp06.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 17 Nov 2014 11:34:18 +0530 Received: from d28relay03.in.ibm.com (d28relay03.in.ibm.com [9.184.220.60]) by d28dlp03.in.ibm.com (Postfix) with ESMTP id 5B0DA1258053 for ; Mon, 17 Nov 2014 11:34:21 +0530 (IST) Received: from d28av01.in.ibm.com (d28av01.in.ibm.com [9.184.220.63]) by d28relay03.in.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id sAH66PSk721232 for ; Mon, 17 Nov 2014 11:36:25 +0530 Received: from d28av01.in.ibm.com (localhost [127.0.0.1]) by d28av01.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id sAH64DkG031478 for ; Mon, 17 Nov 2014 11:34:14 +0530 Message-ID: <54698F7E.6090300@linux.vnet.ibm.com> Date: Mon, 17 Nov 2014 11:32:38 +0530 From: Neelesh Gupta MIME-Version: 1.0 To: devicetree@vger.kernel.org, tglx@linutronix.de, linuxppc-dev@lists.ozlabs.org, rtc-linux@googlegroups.com, a.zummo@towertech.it Subject: Re: [PATCH v3] rtc/tpo: Driver to support rtc and wakeup on PowerNV platform References: <20141014083447.7505.89771.stgit@localhost.localdomain> <54476F4B.8050108@linux.vnet.ibm.com> In-Reply-To: <54476F4B.8050108@linux.vnet.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Cc: benh@au1.ibm.com List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 10/22/2014 02:18 PM, Neelesh Gupta wrote: > > On 10/14/2014 02:08 PM, Neelesh Gupta wrote: >> The patch implements the OPAL rtc driver that binds with the rtc >> driver subsystem. The driver uses the platform device infrastructure >> to probe the rtc device and register it to rtc class framework. The >> 'wakeup' is supported depending upon the property 'has-tpo' present >> in the OF node. It provides a way to load the generic rtc driver in >> in the absence of an OPAL driver. >> >> The patch also moves the existing OPAL rtc get/set time interfaces to >> the >> new driver and exposes the necessary OPAL calls using EXPORT_SYMBOL_GPL. > > Hi Alessandro, > > Awaiting Ack from your side, so that we can take this through the > powerpc tree. Hi Alessandro, Please acknowledge.. - Neelesh > > Regards, > Neelesh > >> >> Test results: >> ------------- >> Host: >> [root@tul169p1 ~]# ls -l /sys/class/rtc/ >> total 0 >> lrwxrwxrwx 1 root root 0 Oct 14 03:07 rtc0 -> >> ../../devices/opal-rtc/rtc/rtc0 >> [root@tul169p1 ~]# cat /sys/devices/opal-rtc/rtc/rtc0/time >> 08:10:07 >> [root@tul169p1 ~]# echo `date '+%s' -d '+ 2 minutes'` > >> /sys/class/rtc/rtc0/wakealarm >> [root@tul169p1 ~]# cat /sys/class/rtc/rtc0/wakealarm >> 1413274345 >> [root@tul169p1 ~]# >> >> FSP: >> $ smgr mfgState >> standby >> $ rtim timeofday >> >> System time is valid: 2014/10/14 08:12:04.225115 >> >> $ smgr mfgState >> ipling >> $ >> >> Signed-off-by: Neelesh Gupta >> --- >> >> Changes in v3 >> ============= >> - Rebased to the latest tree. >> >> Changes in v2 >> ============= >> - Added Documentation/devicetree/bindings/rtc/rtc-opal.txt >> - Explicitly turn off RTC_UIE mode by setting 'rtc->uie_unsupported' >> >> Documentation/devicetree/bindings/rtc/rtc-opal.txt | 16 + >> arch/powerpc/include/asm/opal.h | 7 - >> arch/powerpc/kernel/time.c | 1 >> arch/powerpc/platforms/powernv/opal-async.c | 3 >> arch/powerpc/platforms/powernv/opal-rtc.c | 65 +---- >> arch/powerpc/platforms/powernv/opal-wrappers.S | 2 >> arch/powerpc/platforms/powernv/opal.c | 6 >> arch/powerpc/platforms/powernv/setup.c | 2 >> drivers/rtc/Kconfig | 11 + >> drivers/rtc/Makefile | 1 >> drivers/rtc/rtc-opal.c | 261 >> ++++++++++++++++++++ >> 11 files changed, 325 insertions(+), 50 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/rtc/rtc-opal.txt >> create mode 100644 drivers/rtc/rtc-opal.c >> > > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/linuxppc-dev