* [PATCH] cpuidle/powernv: Re-enable fastsleep at boot time
@ 2014-11-18 6:56 Preeti U Murthy
2014-11-19 2:34 ` Joel Stanley
0 siblings, 1 reply; 3+ messages in thread
From: Preeti U Murthy @ 2014-11-18 6:56 UTC (permalink / raw)
To: mpe, mikey, joel.stanley; +Cc: linuxppc-dev, linux-kernel, rjw
Commit dcb18694 "Fix ipi on palmeto" disabled fastsleep at boot time.
Revert this commit since we no longer need this fix. However we can
continue to use powersave_nap parameter to control entry into deep
idle states beyond snooze.
Signed-off-by: Preeti U. Murthy <preeti@linux.vnet.ibm.com>
---
drivers/cpuidle/cpuidle-powernv.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/cpuidle/cpuidle-powernv.c b/drivers/cpuidle/cpuidle-powernv.c
index b57681d..b430e76 100644
--- a/drivers/cpuidle/cpuidle-powernv.c
+++ b/drivers/cpuidle/cpuidle-powernv.c
@@ -69,8 +69,9 @@ static int fastsleep_loop(struct cpuidle_device *dev,
unsigned long old_lpcr = mfspr(SPRN_LPCR);
unsigned long new_lpcr;
- if (powersave_nap < 2)
- return;
+ if (!(powersave_nap > 0))
+ return index;
+
if (unlikely(system_state < SYSTEM_RUNNING))
return index;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] cpuidle/powernv: Re-enable fastsleep at boot time
2014-11-18 6:56 [PATCH] cpuidle/powernv: Re-enable fastsleep at boot time Preeti U Murthy
@ 2014-11-19 2:34 ` Joel Stanley
2014-11-19 7:08 ` Preeti U Murthy
0 siblings, 1 reply; 3+ messages in thread
From: Joel Stanley @ 2014-11-19 2:34 UTC (permalink / raw)
To: Preeti U Murthy; +Cc: Michael Neuling, linuxppc-dev, linux-kernel, rjw
Hey Preeti,
On Tue, Nov 18, 2014 at 5:26 PM, Preeti U Murthy
<preeti@linux.vnet.ibm.com> wrote:
> Commit dcb18694 "Fix ipi on palmeto" disabled fastsleep at boot time.
I couldn't find this commit in any tree; upstream, mpe's next, nor powerkvm.
I remember testing this as a workaround for the palmetto, but I don't
recall sending it upstream.
Cheers,
Joel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] cpuidle/powernv: Re-enable fastsleep at boot time
2014-11-19 2:34 ` Joel Stanley
@ 2014-11-19 7:08 ` Preeti U Murthy
0 siblings, 0 replies; 3+ messages in thread
From: Preeti U Murthy @ 2014-11-19 7:08 UTC (permalink / raw)
To: Joel Stanley; +Cc: Michael Neuling, linuxppc-dev, linux-kernel, rjw
Hi Joel,
On 11/19/2014 08:04 AM, Joel Stanley wrote:
> Hey Preeti,
>
> On Tue, Nov 18, 2014 at 5:26 PM, Preeti U Murthy
> <preeti@linux.vnet.ibm.com> wrote:
>> Commit dcb18694 "Fix ipi on palmeto" disabled fastsleep at boot time.
>
> I couldn't find this commit in any tree; upstream, mpe's next, nor powerkvm.
Oh yes you are right. I must have been looking at the wrong git branch.
I verified upstream now. The commit dcb18694 is not present.So we are
good. Thanks for pointing this out :)
Sorry for the noise!
>
> I remember testing this as a workaround for the palmetto, but I don't
> recall sending it upstream.
>
> Cheers,
>
> Joel
>
Regards
Preeti U Murthy
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-11-19 7:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-18 6:56 [PATCH] cpuidle/powernv: Re-enable fastsleep at boot time Preeti U Murthy
2014-11-19 2:34 ` Joel Stanley
2014-11-19 7:08 ` Preeti U Murthy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).