From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [119.145.14.65]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 835F61A0733 for ; Thu, 20 Nov 2014 13:02:16 +1100 (AEDT) Message-ID: <546D4B49.6020408@huawei.com> Date: Thu, 20 Nov 2014 10:00:41 +0800 From: Yijing Wang MIME-Version: 1.0 To: Liviu Dudau Subject: Re: [RFC PATCH 07/16] PCI: Separate pci_host_bridge creation out of pci_create_root_bus() References: <1416219710-26088-1-git-send-email-wangyijing@huawei.com> <1416219710-26088-8-git-send-email-wangyijing@huawei.com> <2507218.mHliopJb05@wuerfel> <546B041A.4060403@huawei.com> <20141118144819.GK12037@e106497-lin.cambridge.arm.com> <546BFF74.4030101@huawei.com> <20141119162914.GB9162@bart.dudau.co.uk> In-Reply-To: <20141119162914.GB9162@bart.dudau.co.uk> Content-Type: text/plain; charset="UTF-8" Cc: Tony Luck , Russell King , Arnd Bergmann , "linux-pci@vger.kernel.org" , "x86@kernel.org" , Liviu Dudau , "linux-kernel@vger.kernel.org" , "huxinwei@huawei.com" , Thierry Reding , "suravee.suthikulpanit@amd.com" , Bjorn Helgaas , "linux-ia64@vger.kernel.org" , Thomas Gleixner , Wuyun , "linuxppc-dev@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , >>> Something like this: >>> >>> struct pci_controller { >>> struct pci_host_bridge bridge; >>> /* private host bridge data here */ >>> ..... >>> }; >>> >>> #define PCI_CONTROLLER(bus) ({ >>> struct pci_host_bridge *hb = to_pci_host_bridge(bus->bridge); \ >>> container_of(hb, struct pci_controller, bridge); }) >>> >>> >>> Then we can retrieve the host bridge structure from everywhere we have a device. >> >> Hi Liviu, it looks good to me, because this change will involve lots platforms, >> I would think more about it. Thanks for your suggestion very much! :) > > Given that I also look at this area maybe we should join forces and divide the problem? That's better, we could cooperate to do this. :) > > Best regards, > Liviu > >> >> >> Thanks! >> Yijing. >> >>> >>> Best regards, >>> Liviu >>> >>>> >>>>> >>>>>> + host = kzalloc(sizeof(*host), GFP_KERNEL); >>>>>> + if (!host) >>>>>> + return NULL; >>>>> >>>>> devm_kzalloc maybe? >>>> >>>> I don't know much detail about devm_kzalloc(), but we have no pci host driver >>>> here, and I found no devm_kzalloc() uses in core PCI code before. >>>> >>>>> >>>>>> + if (!resources) { >>>>>> + /* Use default IO/MEM/BUS resources*/ >>>>>> + pci_add_resource(&host->windows, &ioport_resource); >>>>>> + pci_add_resource(&host->windows, &iomem_resource); >>>>>> + pci_add_resource(&host->windows, &busn_resource); >>>>>> + } else { >>>>>> + list_for_each_entry_safe(window, n, resources, list) >>>>>> + list_move_tail(&window->list, &host->windows); >>>>>> + } >>>>> >>>>> I think we should assume that the correct resources are passed. You >>>>> could add a wrapper around this function to convert old platforms >>>>> though. >>>> >>>> OK, I will move these code out of pci_create_host_bridge, and add a wrapper >>>> to setup the default resources. >>>> >>>>> >>>>>> +EXPORT_SYMBOL(pci_create_host_bridge); >>>>> >>>>> EXPORT_SYMBOL_GPL() maybe? >>>> >>>> OK, will update it. >>>> >>>>> >>>>>> diff --git a/include/linux/pci.h b/include/linux/pci.h >>>>>> index 8b11b38..daa7f40 100644 >>>>>> --- a/include/linux/pci.h >>>>>> +++ b/include/linux/pci.h >>>>>> @@ -402,7 +402,12 @@ struct pci_host_bridge_window { >>>>>> struct pci_host_bridge { >>>>>> struct device dev; >>>>>> struct pci_bus *bus; /* root bus */ >>>>>> + struct list_head list; >>>>>> struct list_head windows; /* pci_host_bridge_windows */ >>>>>> + int busnum; >>>>> >>>>> The busnum should already be implied through the bus resource. >>>> >>>> Yes, I will consider remove it and introduce a helper function to get the root bus number, thanks! >>>> >>>> Thanks! >>>> Yijing. >>>> >>>>> >>>>> Arnd >>>>> >>>>> . >>>>> >>>> >>>> >>>> -- >>>> Thanks! >>>> Yijing >>>> >>>> -- >>>> To unsubscribe from this list: send the line "unsubscribe linux-pci" in >>>> the body of a message to majordomo@vger.kernel.org >>>> More majordomo info at http://vger.kernel.org/majordomo-info.html >>>> >>> >> >> >> -- >> Thanks! >> Yijing >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> Please read the FAQ at http://www.tux.org/lkml/ >> > -- Thanks! Yijing