From: Lars-Peter Clausen <lars@metafoo.de>
To: Timur Tabi <timur@tabi.org>, Markus Pargmann <mpa@pengutronix.de>,
Jiada Wang <jiada_wang@mentor.com>
Cc: alsa-devel@alsa-project.org, tiwai@suse.de, broonie@kernel.org,
lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
nicoleotsuka@gmail.com, Li.Xiubo@freescale.com,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [alsa-devel] [PATCH] ASoC: fsl_ssi: free irq before irq_dispose_mapping()
Date: Mon, 01 Dec 2014 17:59:06 +0100 [thread overview]
Message-ID: <547C9E5A.8040307@metafoo.de> (raw)
In-Reply-To: <547C9CAD.1000008@tabi.org>
On 12/01/2014 05:51 PM, Timur Tabi wrote:
> On 12/01/2014 10:49 AM, Lars-Peter Clausen wrote:
>
>> The driver creates the mapping by calling irq_of_parse_and_map(), so it
>> also has to dispose the mapping. But the easy way out is to simply use
>> platform_get_irq() instead of irq_of_parse_map(). In this case the
>> mapping is not managed by the device but by the of core, so the device
>> has not to dispose the mapping.
>
> Is this a problem unique to the SSI driver? Maybe devm_free_irq() should
> also dispose of the mapping?
>
If the mapping was not created by the device, the device shouldn't dispose
it. Mapping and requesting the interrupt are two independent operations.
next prev parent reply other threads:[~2014-12-01 17:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-01 2:50 [PATCH] ASoC: fsl_ssi: free irq before irq_dispose_mapping() Jiada Wang
2014-12-01 6:50 ` Markus Pargmann
2014-12-01 16:49 ` [alsa-devel] " Lars-Peter Clausen
2014-12-01 16:51 ` Timur Tabi
2014-12-01 16:59 ` Lars-Peter Clausen [this message]
2014-12-01 18:48 ` Timur Tabi
2014-12-01 19:39 ` Lars-Peter Clausen
2014-12-01 19:41 ` Mark Brown
2014-12-01 19:56 ` Arnd Bergmann
2014-12-01 19:59 ` Timur Tabi
2014-12-01 20:01 ` Arnd Bergmann
2014-12-01 20:11 ` Timur Tabi
2014-12-01 20:30 ` Lars-Peter Clausen
2014-12-01 20:40 ` Fabio Estevam
2014-12-01 20:42 ` Timur Tabi
2014-12-01 21:03 ` Fabio Estevam
2014-12-01 20:16 ` Mark Brown
2014-12-01 19:24 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547C9E5A.8040307@metafoo.de \
--to=lars@metafoo.de \
--cc=Li.Xiubo@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jiada_wang@mentor.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpa@pengutronix.de \
--cc=nicoleotsuka@gmail.com \
--cc=timur@tabi.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).