From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out-248.synserver.de (smtp-out-248.synserver.de [212.40.185.248]) by lists.ozlabs.org (Postfix) with ESMTP id 5A0A61A0064 for ; Tue, 2 Dec 2014 04:00:18 +1100 (AEDT) Message-ID: <547C9E5A.8040307@metafoo.de> Date: Mon, 01 Dec 2014 17:59:06 +0100 From: Lars-Peter Clausen MIME-Version: 1.0 To: Timur Tabi , Markus Pargmann , Jiada Wang Subject: Re: [alsa-devel] [PATCH] ASoC: fsl_ssi: free irq before irq_dispose_mapping() References: <1417402251-6596-1-git-send-email-jiada_wang@mentor.com> <20141201065046.GB27289@pengutronix.de> <547C9C34.9080602@metafoo.de> <547C9CAD.1000008@tabi.org> In-Reply-To: <547C9CAD.1000008@tabi.org> Content-Type: text/plain; charset=windows-1252; format=flowed Cc: alsa-devel@alsa-project.org, tiwai@suse.de, broonie@kernel.org, lgirdwood@gmail.com, linux-kernel@vger.kernel.org, nicoleotsuka@gmail.com, Li.Xiubo@freescale.com, linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 12/01/2014 05:51 PM, Timur Tabi wrote: > On 12/01/2014 10:49 AM, Lars-Peter Clausen wrote: > >> The driver creates the mapping by calling irq_of_parse_and_map(), so it >> also has to dispose the mapping. But the easy way out is to simply use >> platform_get_irq() instead of irq_of_parse_map(). In this case the >> mapping is not managed by the device but by the of core, so the device >> has not to dispose the mapping. > > Is this a problem unique to the SSI driver? Maybe devm_free_irq() should > also dispose of the mapping? > If the mapping was not created by the device, the device shouldn't dispose it. Mapping and requesting the interrupt are two independent operations.