From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from muin.pair.com (muin.pair.com [209.68.1.55]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 048071A0060 for ; Tue, 2 Dec 2014 07:11:39 +1100 (AEDT) Message-ID: <547CCB78.5090007@tabi.org> Date: Mon, 01 Dec 2014 14:11:36 -0600 From: Timur Tabi MIME-Version: 1.0 To: Arnd Bergmann Subject: Re: [alsa-devel] [PATCH] ASoC: fsl_ssi: free irq before irq_dispose_mapping() References: <1417402251-6596-1-git-send-email-jiada_wang@mentor.com> <2547588.Qc4F2IfZke@wuerfel> <547CC89F.1030205@tabi.org> <3401240.VsRpsiV8WN@wuerfel> In-Reply-To: <3401240.VsRpsiV8WN@wuerfel> Content-Type: text/plain; charset=windows-1252; format=flowed Cc: alsa-devel@alsa-project.org, Lars-Peter Clausen , Jiada Wang , Li.Xiubo@freescale.com, linux-kernel@vger.kernel.org, lgirdwood@gmail.com, nicoleotsuka@gmail.com, tiwai@suse.de, Mark Brown , Markus Pargmann , linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 12/01/2014 02:01 PM, Arnd Bergmann wrote: >> >Does this mean that fsl_ssi.c should not be calling >> >irq_of_parse_and_map? How else should it get the IRQ? > platform_get_irq() Ok, but that function also calls irq_create_of_mapping(). So it still appears that the only way to get the IRQ is to map it, but then we can't use devm_request_irq().