From: Daniel Ng <daniel.ng1234@gmail.com>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: "linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>,
Norbert van Bolhuis <nvbolhuis@aimvalley.nl>
Subject: Re: MPC8272- Porting HDLC driver from 2.6.14 to 2.6.27- "no_irq_chip" error
Date: Fri, 29 May 2009 10:46:30 +1000 [thread overview]
Message-ID: <547eba1b0905281746h970028br9685085d18dceb6e@mail.gmail.com> (raw)
In-Reply-To: <20090528123311.GA3112@pengutronix.de>
On Thu, May 28, 2009 at 10:33 PM, Wolfram Sang <w.sang@pengutronix.de> wrote:
>> this is an example of how a simple 8313 Periodic Interval Timer (PIT) kernel driver
>> registers for the PIT IRQ (Interrupt ID 65)
>>
>> #define PIT_IRQ 65
>>
>> virq = irq_create_mapping(NULL, PIT_IRQ);
>> set_irq_type(virq, IRQ_TYPE_LEVEL_LOW);
>>
>> if(request_irq(virq, (irq_handler_t)timerEvent, 0, "timer2", (void *)0)) {
>> printk(KERN_ERR "request_irq() returned error for irq=%d virq=%d\n", PIT_IRQ, virq);
>> }
>
> It is some time ago, but when I did something similar I needed the
> following patch in order to use NULL for irq_create_mapping(). Have a
> try, and if it is still needed (as it looks from a glimpse), then maybe
> we should get it merged?
>
> ===
>
> From: Wolfram Sang <w.sang@pengutronix.de>
> Subject: [PATCH] powerpc/cpm2: make cpm2_pic the default host
>
> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
> ---
> arch/powerpc/sysdev/cpm2_pic.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/powerpc/sysdev/cpm2_pic.c b/arch/powerpc/sysdev/cpm2_pic.c
> index 78f1f7c..7a7d4e5 100644
> --- a/arch/powerpc/sysdev/cpm2_pic.c
> +++ b/arch/powerpc/sysdev/cpm2_pic.c
> @@ -272,4 +272,5 @@ void cpm2_pic_init(struct device_node *node)
> printk(KERN_ERR "CPM2 PIC: failed to allocate irq host!\n");
> return;
> }
> + irq_set_default_host(cpm2_pic_host);
> }
Thanks guys.
I can confirm that Wolfram's patch above is required to get Norbet's
suggestion to work. Without the patch, I still get the original
symptoms. I have tested this on 2.6.27.19.
Daniel
next prev parent reply other threads:[~2009-05-29 0:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-28 7:37 MPC8272- Porting HDLC driver from 2.6.14 to 2.6.27- "no_irq_chip" error Daniel Ng
2009-05-28 10:33 ` Norbert van Bolhuis
2009-05-28 12:33 ` Wolfram Sang
2009-05-29 0:46 ` Daniel Ng [this message]
2009-05-29 8:31 ` [PATCH] powerpc/cpm2: make cpm2_pic the default host Wolfram Sang
2009-05-29 10:56 ` MPC8272- Porting HDLC driver from 2.6.14 to 2.6.27- "no_irq_chip" error Frank Svendsbøe
2009-05-29 17:18 ` Scott Wood
2009-05-30 20:22 ` Frank Svendsbøe
2009-06-02 0:48 ` Benjamin Herrenschmidt
2009-06-02 0:47 ` Benjamin Herrenschmidt
2009-06-02 4:38 ` Wolfram Sang
2009-06-02 4:42 ` Benjamin Herrenschmidt
2009-06-02 0:46 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547eba1b0905281746h970028br9685085d18dceb6e@mail.gmail.com \
--to=daniel.ng1234@gmail.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=nvbolhuis@aimvalley.nl \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).