* ppc64 and Documentation/mic/mpssd/mpssd.c issues
@ 2014-12-04 13:41 Daniel Borkmann
2014-12-04 16:48 ` Yokoyama, Caz
0 siblings, 1 reply; 6+ messages in thread
From: Daniel Borkmann @ 2014-12-04 13:41 UTC (permalink / raw)
To: Caz.Yokoyama; +Cc: linuxppc-dev
Hi Caz,
I think commit ...
commit 8d49751580db804a02caf6a5b7cebe2ff26c0d7e
Author: Caz Yokoyama <Caz.Yokoyama@intel.com>
Date: Thu Sep 5 16:42:39 2013 -0700
Sample Implementation of Intel MIC User Space Daemon.
... actually triggers a build error on my default config
ppc64 (I'm using net-next tree):
HOSTCC Documentation/mic/mpssd/mpssd.o
Documentation/mic/mpssd/mpssd.c:93: error: braced-group within expression allowed only inside a function
Documentation/mic/mpssd/mpssd.c:96: error: braced-group within expression allowed only inside a function
Documentation/mic/mpssd/mpssd.c:113: error: braced-group within expression allowed only inside a function
Documentation/mic/mpssd/mpssd.c:116: error: braced-group within expression allowed only inside a function
Documentation/mic/mpssd/mpssd.c:119: error: braced-group within expression allowed only inside a function
Documentation/mic/mpssd/mpssd.c:146: error: braced-group within expression allowed only inside a function
Documentation/mic/mpssd/mpssd.c:149: error: braced-group within expression allowed only inside a function
Documentation/mic/mpssd/mpssd.c:151: error: braced-group within expression allowed only inside a function
Documentation/mic/mpssd/mpssd.c:152: error: braced-group within expression allowed only inside a function
make[3]: *** [Documentation/mic/mpssd/mpssd.o] Error 1
make[2]: *** [Documentation/mic/mpssd] Error 2
make[1]: *** [Documentation/mic] Error 2
make: *** [vmlinux] Error 2
gcc --version
gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-11)
Cheers,
Daniel
^ permalink raw reply [flat|nested] 6+ messages in thread* RE: ppc64 and Documentation/mic/mpssd/mpssd.c issues 2014-12-04 13:41 ppc64 and Documentation/mic/mpssd/mpssd.c issues Daniel Borkmann @ 2014-12-04 16:48 ` Yokoyama, Caz 2014-12-04 16:57 ` Sudeep Dutt 2014-12-04 20:29 ` Benjamin Herrenschmidt 0 siblings, 2 replies; 6+ messages in thread From: Yokoyama, Caz @ 2014-12-04 16:48 UTC (permalink / raw) To: Daniel Borkmann Cc: Dixit, Ashutosh, linuxppc-dev@lists.ozlabs.org, Dutt, Sudeep Thank you for the report. Have you tried to compile on x86_64? Which rhel do you use? Rhel6.X? MIC card is expected to work with x86_64 host, not with ppc64. We have neve= r compiled on ppc host while our primary development platform was rhel6.X. Line 92 is the first use of htole16 and MIC_VRING_ENTRIES. Is there any cha= nge on them? Thank you. -caz, Caz.Yokoyama@intel.com, yokoyama@member.fsf.org -----Original Message----- From: Daniel Borkmann [mailto:dborkman@redhat.com]=20 Sent: Thursday, December 04, 2014 5:42 AM To: Yokoyama, Caz Cc: benh@kernel.crashing.org; linuxppc-dev@lists.ozlabs.org Subject: ppc64 and Documentation/mic/mpssd/mpssd.c issues Hi Caz, I think commit ... commit 8d49751580db804a02caf6a5b7cebe2ff26c0d7e Author: Caz Yokoyama <Caz.Yokoyama@intel.com> Date: Thu Sep 5 16:42:39 2013 -0700 Sample Implementation of Intel MIC User Space Daemon. ... actually triggers a build error on my default config ppc64 (I'm using net-next tree): HOSTCC Documentation/mic/mpssd/mpssd.o Documentation/mic/mpssd/mpssd.c:93: error: braced-group within expression a= llowed only inside a function Documentation/mic/mpssd/mpssd.c:96: error: braced-group within expression a= llowed only inside a function Documentation/mic/mpssd/mpssd.c:113: error: braced-group within expression = allowed only inside a function Documentation/mic/mpssd/mpssd.c:116: error: braced-group within expression = allowed only inside a function Documentation/mic/mpssd/mpssd.c:119: error: braced-group within expression = allowed only inside a function Documentation/mic/mpssd/mpssd.c:146: error: braced-group within expression = allowed only inside a function Documentation/mic/mpssd/mpssd.c:149: error: braced-group within expression = allowed only inside a function Documentation/mic/mpssd/mpssd.c:151: error: braced-group within expression = allowed only inside a function Documentation/mic/mpssd/mpssd.c:152: error: braced-group within expression = allowed only inside a function make[3]: *** [Documentation/mic/mpssd/mpssd.o] Error 1 make[2]: *** [Documentation/mic/mpssd] Error 2 make[1]: *** [Documentation/mic] Error 2 make: *** [vmlinux] Error 2 gcc --version gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-11) Cheers, Daniel ^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: ppc64 and Documentation/mic/mpssd/mpssd.c issues 2014-12-04 16:48 ` Yokoyama, Caz @ 2014-12-04 16:57 ` Sudeep Dutt 2014-12-04 17:01 ` Peter Foley 2014-12-04 17:02 ` Daniel Borkmann 2014-12-04 20:29 ` Benjamin Herrenschmidt 1 sibling, 2 replies; 6+ messages in thread From: Sudeep Dutt @ 2014-12-04 16:57 UTC (permalink / raw) To: Yokoyama, Caz, Peter Foley Cc: Dixit, Ashutosh, Daniel Borkmann, linuxppc-dev@lists.ozlabs.org, Sudeep Dutt On Thu, 2014-12-04 at 08:48 -0800, Yokoyama, Caz wrote: > Thank you for the report. > Have you tried to compile on x86_64? Which rhel do you use? Rhel6.X? > MIC card is expected to work with x86_64 host, not with ppc64. We have never compiled on ppc host while our primary development platform was rhel6.X. > I am adding Peter Foley since he enabled the mpssd build by default recently with commit adb19fb. Peter, is there a way to enable the mpssd build only for x86_64? Thanks, Sudeep Dutt > Line 92 is the first use of htole16 and MIC_VRING_ENTRIES. Is there any change on them? > > Thank you. > -caz, Caz.Yokoyama@intel.com, yokoyama@member.fsf.org > > > -----Original Message----- > From: Daniel Borkmann [mailto:dborkman@redhat.com] > Sent: Thursday, December 04, 2014 5:42 AM > To: Yokoyama, Caz > Cc: benh@kernel.crashing.org; linuxppc-dev@lists.ozlabs.org > Subject: ppc64 and Documentation/mic/mpssd/mpssd.c issues > > Hi Caz, > > I think commit ... > > commit 8d49751580db804a02caf6a5b7cebe2ff26c0d7e > Author: Caz Yokoyama <Caz.Yokoyama@intel.com> > Date: Thu Sep 5 16:42:39 2013 -0700 > > Sample Implementation of Intel MIC User Space Daemon. > > ... actually triggers a build error on my default config > ppc64 (I'm using net-next tree): > > HOSTCC Documentation/mic/mpssd/mpssd.o > Documentation/mic/mpssd/mpssd.c:93: error: braced-group within expression allowed only inside a function > Documentation/mic/mpssd/mpssd.c:96: error: braced-group within expression allowed only inside a function > Documentation/mic/mpssd/mpssd.c:113: error: braced-group within expression allowed only inside a function > Documentation/mic/mpssd/mpssd.c:116: error: braced-group within expression allowed only inside a function > Documentation/mic/mpssd/mpssd.c:119: error: braced-group within expression allowed only inside a function > Documentation/mic/mpssd/mpssd.c:146: error: braced-group within expression allowed only inside a function > Documentation/mic/mpssd/mpssd.c:149: error: braced-group within expression allowed only inside a function > Documentation/mic/mpssd/mpssd.c:151: error: braced-group within expression allowed only inside a function > Documentation/mic/mpssd/mpssd.c:152: error: braced-group within expression allowed only inside a function > make[3]: *** [Documentation/mic/mpssd/mpssd.o] Error 1 > make[2]: *** [Documentation/mic/mpssd] Error 2 > make[1]: *** [Documentation/mic] Error 2 > make: *** [vmlinux] Error 2 > > gcc --version > gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-11) > > Cheers, > Daniel ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: ppc64 and Documentation/mic/mpssd/mpssd.c issues 2014-12-04 16:57 ` Sudeep Dutt @ 2014-12-04 17:01 ` Peter Foley 2014-12-04 17:02 ` Daniel Borkmann 1 sibling, 0 replies; 6+ messages in thread From: Peter Foley @ 2014-12-04 17:01 UTC (permalink / raw) To: Sudeep Dutt Cc: Dixit, Ashutosh, Daniel Borkmann, linuxppc-dev@lists.ozlabs.org, Yokoyama, Caz On Thu, Dec 4, 2014 at 11:57 AM, Sudeep Dutt <sudeep.dutt@intel.com> wrote: > On Thu, 2014-12-04 at 08:48 -0800, Yokoyama, Caz wrote: >> Thank you for the report. >> Have you tried to compile on x86_64? Which rhel do you use? Rhel6.X? >> MIC card is expected to work with x86_64 host, not with ppc64. We have never compiled on ppc host while our primary development platform was rhel6.X. >> > > I am adding Peter Foley since he enabled the mpssd build by default > recently with commit adb19fb. Peter, is there a way to enable the mpssd > build only for x86_64? Change hostprogs-y to hostprogs-$(CONFIG_X86_64) in the mpssd Makefile. That will restrict it to x86_64 only. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: ppc64 and Documentation/mic/mpssd/mpssd.c issues 2014-12-04 16:57 ` Sudeep Dutt 2014-12-04 17:01 ` Peter Foley @ 2014-12-04 17:02 ` Daniel Borkmann 1 sibling, 0 replies; 6+ messages in thread From: Daniel Borkmann @ 2014-12-04 17:02 UTC (permalink / raw) To: Sudeep Dutt Cc: Dixit, Ashutosh, linuxppc-dev@lists.ozlabs.org, Yokoyama, Caz, Peter Foley On 12/04/2014 05:57 PM, Sudeep Dutt wrote: > On Thu, 2014-12-04 at 08:48 -0800, Yokoyama, Caz wrote: >> Thank you for the report. >> Have you tried to compile on x86_64? Which rhel do you use? Rhel6.X? >> MIC card is expected to work with x86_64 host, not with ppc64. We have never compiled on ppc host while our primary development platform was rhel6.X. Yep, I was using RHEL6 on ppc64 by chance to build an upstream kernel. You might want to fix the Kconfig entry then to limit this to x86_64 only. ;) Thanks, Daniel > I am adding Peter Foley since he enabled the mpssd build by default > recently with commit adb19fb. Peter, is there a way to enable the mpssd > build only for x86_64? > > Thanks, > Sudeep Dutt > >> Line 92 is the first use of htole16 and MIC_VRING_ENTRIES. Is there any change on them? >> >> Thank you. >> -caz, Caz.Yokoyama@intel.com, yokoyama@member.fsf.org >> >> >> -----Original Message----- >> From: Daniel Borkmann [mailto:dborkman@redhat.com] >> Sent: Thursday, December 04, 2014 5:42 AM >> To: Yokoyama, Caz >> Cc: benh@kernel.crashing.org; linuxppc-dev@lists.ozlabs.org >> Subject: ppc64 and Documentation/mic/mpssd/mpssd.c issues >> >> Hi Caz, >> >> I think commit ... >> >> commit 8d49751580db804a02caf6a5b7cebe2ff26c0d7e >> Author: Caz Yokoyama <Caz.Yokoyama@intel.com> >> Date: Thu Sep 5 16:42:39 2013 -0700 >> >> Sample Implementation of Intel MIC User Space Daemon. >> >> ... actually triggers a build error on my default config >> ppc64 (I'm using net-next tree): >> >> HOSTCC Documentation/mic/mpssd/mpssd.o >> Documentation/mic/mpssd/mpssd.c:93: error: braced-group within expression allowed only inside a function >> Documentation/mic/mpssd/mpssd.c:96: error: braced-group within expression allowed only inside a function >> Documentation/mic/mpssd/mpssd.c:113: error: braced-group within expression allowed only inside a function >> Documentation/mic/mpssd/mpssd.c:116: error: braced-group within expression allowed only inside a function >> Documentation/mic/mpssd/mpssd.c:119: error: braced-group within expression allowed only inside a function >> Documentation/mic/mpssd/mpssd.c:146: error: braced-group within expression allowed only inside a function >> Documentation/mic/mpssd/mpssd.c:149: error: braced-group within expression allowed only inside a function >> Documentation/mic/mpssd/mpssd.c:151: error: braced-group within expression allowed only inside a function >> Documentation/mic/mpssd/mpssd.c:152: error: braced-group within expression allowed only inside a function >> make[3]: *** [Documentation/mic/mpssd/mpssd.o] Error 1 >> make[2]: *** [Documentation/mic/mpssd] Error 2 >> make[1]: *** [Documentation/mic] Error 2 >> make: *** [vmlinux] Error 2 >> >> gcc --version >> gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-11) >> >> Cheers, >> Daniel > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: ppc64 and Documentation/mic/mpssd/mpssd.c issues 2014-12-04 16:48 ` Yokoyama, Caz 2014-12-04 16:57 ` Sudeep Dutt @ 2014-12-04 20:29 ` Benjamin Herrenschmidt 1 sibling, 0 replies; 6+ messages in thread From: Benjamin Herrenschmidt @ 2014-12-04 20:29 UTC (permalink / raw) To: Yokoyama, Caz Cc: Dixit, Ashutosh, Daniel Borkmann, linuxppc-dev@lists.ozlabs.org, Dutt, Sudeep On Thu, 2014-12-04 at 16:48 +0000, Yokoyama, Caz wrote: > Thank you for the report. > Have you tried to compile on x86_64? Which rhel do you use? Rhel6.X? > MIC card is expected to work with x86_64 host, not with ppc64. We have never compiled on ppc host while our primary development platform was rhel6.X. > > Line 92 is the first use of htole16 and MIC_VRING_ENTRIES. Is there any change on them? Then you should make sure your Kconfig/Makefile stanza only compiles it on x86_64 instead of breaking all other architectures... Ben. > Thank you. > -caz, Caz.Yokoyama@intel.com, yokoyama@member.fsf.org > > > -----Original Message----- > From: Daniel Borkmann [mailto:dborkman@redhat.com] > Sent: Thursday, December 04, 2014 5:42 AM > To: Yokoyama, Caz > Cc: benh@kernel.crashing.org; linuxppc-dev@lists.ozlabs.org > Subject: ppc64 and Documentation/mic/mpssd/mpssd.c issues > > Hi Caz, > > I think commit ... > > commit 8d49751580db804a02caf6a5b7cebe2ff26c0d7e > Author: Caz Yokoyama <Caz.Yokoyama@intel.com> > Date: Thu Sep 5 16:42:39 2013 -0700 > > Sample Implementation of Intel MIC User Space Daemon. > > ... actually triggers a build error on my default config > ppc64 (I'm using net-next tree): > > HOSTCC Documentation/mic/mpssd/mpssd.o > Documentation/mic/mpssd/mpssd.c:93: error: braced-group within expression allowed only inside a function > Documentation/mic/mpssd/mpssd.c:96: error: braced-group within expression allowed only inside a function > Documentation/mic/mpssd/mpssd.c:113: error: braced-group within expression allowed only inside a function > Documentation/mic/mpssd/mpssd.c:116: error: braced-group within expression allowed only inside a function > Documentation/mic/mpssd/mpssd.c:119: error: braced-group within expression allowed only inside a function > Documentation/mic/mpssd/mpssd.c:146: error: braced-group within expression allowed only inside a function > Documentation/mic/mpssd/mpssd.c:149: error: braced-group within expression allowed only inside a function > Documentation/mic/mpssd/mpssd.c:151: error: braced-group within expression allowed only inside a function > Documentation/mic/mpssd/mpssd.c:152: error: braced-group within expression allowed only inside a function > make[3]: *** [Documentation/mic/mpssd/mpssd.o] Error 1 > make[2]: *** [Documentation/mic/mpssd] Error 2 > make[1]: *** [Documentation/mic] Error 2 > make: *** [vmlinux] Error 2 > > gcc --version > gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-11) > > Cheers, > Daniel ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-12-04 20:29 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-12-04 13:41 ppc64 and Documentation/mic/mpssd/mpssd.c issues Daniel Borkmann 2014-12-04 16:48 ` Yokoyama, Caz 2014-12-04 16:57 ` Sudeep Dutt 2014-12-04 17:01 ` Peter Foley 2014-12-04 17:02 ` Daniel Borkmann 2014-12-04 20:29 ` Benjamin Herrenschmidt
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).