linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Anshuman Khandual <khandual@linux.vnet.ibm.com>
To: Michael Ellerman <mpe@ellerman.id.au>, linuxppc-dev@lists.ozlabs.org
Cc: mikey@neuling.org, anton@samba.org
Subject: Re: [1/5] powerpc: Fix handling of DSCR related facility unavailable exception
Date: Tue, 09 Dec 2014 18:45:51 +0530	[thread overview]
Message-ID: <5486F607.6010706@linux.vnet.ibm.com> (raw)
In-Reply-To: <20141209101117.1CEC9140100@ozlabs.org>

On 12/09/2014 03:41 PM, Michael Ellerman wrote:
> On Mon, 2014-08-12 at 06:30:08 UTC, Anshuman Khandual wrote:
>> Currently DSCR (Data Stream Control Register) can be accessed with
>> mfspr or mtspr instructions inside a thread via two different SPR
>> numbers. One being the user accessible problem state SPR number 0x03
>> and the other being the privilege state SPR number 0x11. All access
>> through the privilege state SPR number get emulated through illegal
>> instruction exception. Any access through the problem state SPR number
>> raises one facility unavailable exception which sets the thread based
>> dscr_inherit bit and enables DSCR facility through FSCR register thus
>> allowing direct access to DSCR without going through this exception in
>> the future. We set the thread.dscr_inherit bit whether the access was
>> with mfspr or mtspr instruction which is neither correct nor does it
>> match the behaviour through the instruction emulation code path driven
>> from privilege state SPR number. User currently observes two different
>> kind of behaviour when accessing the DSCR through these two SPR numbers.
>> This problem can be observed through these two test cases by replacing
>> the privilege state SPR number with the problem state SPR number.
>>
>> 	(1) http://ozlabs.org/~anton/junkcode/dscr_default_test.c
>> 	(2) http://ozlabs.org/~anton/junkcode/dscr_explicit_test.c
> 
> Can you convert those into a selftest please?

Hey Michael,

Yeah I wanted to convert all these tests which are related to DSCR into
individual self tests for powerpc. All these test cases have Anton Blanchard
and IBM's copyright on it but they are licensed with GPL V2. Not sure whether
Anton needs to okay this before I can modify them for self tests, put his
(Anton's) signed-off-by and then post it in the mailing list.

(1) http://ozlabs.org/~anton/junkcode/dscr_default_test.c
(2) http://ozlabs.org/~anton/junkcode/dscr_explicit_test.c
(3) http://ozlabs.org/~anton/junkcode/dscr_inherit_exec_test.c
(4) http://ozlabs.org/~anton/junkcode/dscr_inherit_test.c
(5) http://ozlabs.org/~anton/junkcode/user_dscr_test.c

  reply	other threads:[~2014-12-09 13:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-08  6:30 [PATCH 1/5] powerpc: Fix handling of DSCR related facility unavailable exception Anshuman Khandual
2014-12-08  6:30 ` [PATCH 2/5] powerpc, process: Remove the unused extern dscr_default Anshuman Khandual
2014-12-08  6:30 ` [PATCH 3/5] powerpc, offset: Change PACA_DSCR to PACA_DSCR_DEFAULT Anshuman Khandual
2014-12-08  6:30 ` [PATCH 4/5] powerpc, dscr: Added some in-code documentation Anshuman Khandual
2014-12-09 10:03   ` [4/5] " Michael Ellerman
2014-12-09 13:03     ` Anshuman Khandual
2014-12-08  6:30 ` [PATCH 5/5] documentation, powerpc: Add documentation for DSCR support Anshuman Khandual
2014-12-09 10:11 ` [1/5] powerpc: Fix handling of DSCR related facility unavailable exception Michael Ellerman
2014-12-09 13:15   ` Anshuman Khandual [this message]
2014-12-18  5:10     ` Anton Blanchard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5486F607.6010706@linux.vnet.ibm.com \
    --to=khandual@linux.vnet.ibm.com \
    --cc=anton@samba.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mikey@neuling.org \
    --cc=mpe@ellerman.id.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).