From: Nathan Whitehorn <nwhitehorn@freebsd.org>
To: Geoff Levand <geoff@infradead.org>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>,
Andre Heider <a.heider@gmail.com>
Cc: cbe-oss-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] arch: powerpc: platforms: ps3: repository.c: Remove unused function
Date: Mon, 22 Dec 2014 09:36:06 -0800 [thread overview]
Message-ID: <54985686.7080609@freebsd.org> (raw)
In-Reply-To: <1419269161.3786.4.camel@infradead.org>
On 12/22/14 09:26, Geoff Levand wrote:
> On Sat, 2014-12-20 at 16:00 +0100, Rickard Strandqvist wrote:
>> Remove the function ps3_repository_write_highmem_info() that is not used anywhere.
> NAK
>
> ps3_repository_write_highmem_info() is needed by otheros++. What we
> need is a kernel patch to add the highmem info to the repository once it
> is known.
>
> These ps3_repository_write_highmem routines are also the only
> documentation the freeBSD port has as to how the highmem info is (should
> be) saved in the repository.
>
> -Geoff
>
>
Yes, we really need this for FreeBSD since that port uses the repository
directly instead of FDT. Thanks for noticing this. We could adapt
FreeBSD to use FDT (this is the only non-device-tree PowerPC port), but
there hasn't been any reason to do that thus far given the availability
of the repository information.
-Nathan
next prev parent reply other threads:[~2014-12-22 17:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-20 15:00 [PATCH] arch: powerpc: platforms: ps3: repository.c: Remove unused function Rickard Strandqvist
2014-12-22 5:02 ` Michael Ellerman
2014-12-22 17:26 ` [PATCH] " Geoff Levand
2014-12-22 17:36 ` Nathan Whitehorn [this message]
2014-12-22 22:11 ` Rickard Strandqvist
2014-12-23 0:26 ` Michael Ellerman
2014-12-23 2:44 ` Geoff Levand
2014-12-23 5:52 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54985686.7080609@freebsd.org \
--to=nwhitehorn@freebsd.org \
--cc=a.heider@gmail.com \
--cc=cbe-oss-dev@lists.ozlabs.org \
--cc=geoff@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=rickard_strandqvist@spectrumdigital.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).