linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Paul Clarke <pc@us.ibm.com>
To: Michael Ellerman <mpe@ellerman.id.au>, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc: Reword the "returning from prom_init" message
Date: Mon, 12 Jan 2015 11:27:31 -0600	[thread overview]
Message-ID: <54B40403.1000202@us.ibm.com> (raw)
In-Reply-To: <1421056096-20043-1-git-send-email-mpe@ellerman.id.au>

On 01/12/2015 03:48 AM, Michael Ellerman wrote:
> We get way too many bug reports that say "the kernel is hung in
> prom_init", which stems from the fact that the last piece of output
> people see is "returning from prom_init".
>
> The kernel is almost never hung in prom_init(), it's just that it's
> crashed somewhere after prom_init() but prior to the console coming up.
>
> The existing message should give a clue to that, ie. "returning from"
> indicates that prom_init() has finished, but it doesn't seem to work.
> Let's try something different.
>
> This prints:
>
>    Calling quiesce...
>    Shutting down Open Firmware, booting Linux via __start() ...
>
> Which hopefully makes it clear that prom_init() is not the problem, and
> although __start() probably isn't either, it's at least the right place
> to begin looking.

I'm very much in favor of anything that increases usability or decreases 
confusion.

I worry about confusion caused by any phrase that begins "Shutting 
down.."  Even if accurate, I wonder if something more positive that 
indicates that, at least at this point, things are continuing to proceed 
along would be preferred.

Perhaps something like "Transferring control from Open Firmware to 
kernel (via __start) ...".

(Do we know for certain that what is about to be invoked is "Linux" 
per-se, or can it be something else that has a "__start"?)

PC

  reply	other threads:[~2015-01-12 17:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-12  9:48 [PATCH] powerpc: Reword the "returning from prom_init" message Michael Ellerman
2015-01-12 17:27 ` Paul Clarke [this message]
2015-01-13  0:58   ` Michael Ellerman
  -- strict thread matches above, loose matches on Subject: below --
2015-03-30  6:38 Michael Ellerman
2015-04-01  6:56 ` Jeremy Kerr
2015-04-01  9:32   ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54B40403.1000202@us.ibm.com \
    --to=pc@us.ibm.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=mpe@ellerman.id.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).