From: Ryan Grimm <grimm@linux.vnet.ibm.com>
To: Ian Munsie <imunsie@au1.ibm.com>
Cc: mikey <mikey@neuling.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Michael Ellerman <michaele@au1.ibm.com>
Subject: Re: [PATCH 1/4] CXL: Use image state defaults for reloading FPGA
Date: Mon, 19 Jan 2015 12:02:52 -0500 [thread overview]
Message-ID: <54BD38BC.5040305@linux.vnet.ibm.com> (raw)
In-Reply-To: <1421643145-sup-9090@delenn.ozlabs.ibm.com>
On 01/19/2015 12:03 AM, Ian Munsie wrote:
> Acked-by: Ian Munsie <imunsie@au1.ibm.com>
>
> Looks like you forgot your Signed-off-by line - mpe, do you want Ryan to
> resend the whole patch (maybe with the below explanation included), or
> just reply with a Signed-off-by?
OK resending.
-Ryan
>
> This would also be good to CC: Stable, as these new defaults mean that
> the card will be fully reset when sapphire PERSTs them on reboot,
> whereas before it was left up to the default value of this register in
> each card, and could lead to a card getting into a bad state requiring a
> full power cycle to recover. The symptoms we saw was the tlbia / slbia
> we do on boot timing out and the driver init aborting.
>
> Cheers,
> -Ian
>
next prev parent reply other threads:[~2015-01-19 17:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-16 19:48 [PATCH 1/4] CXL: Use image state defaults for reloading FPGA Ryan Grimm
2015-01-16 19:48 ` [PATCH 2/4] CXL: Add image control to sysfs Ryan Grimm
2015-01-19 5:05 ` Ian Munsie
2015-01-16 19:48 ` [PATCH 3/4] CXL: Enable CAPP recovery Ryan Grimm
2015-01-19 5:11 ` Ian Munsie
2015-01-16 19:48 ` [PATCH 4/4] CXL: Add ability to reset the card Ryan Grimm
2015-01-19 5:07 ` Ian Munsie
2015-01-19 5:03 ` [PATCH 1/4] CXL: Use image state defaults for reloading FPGA Ian Munsie
2015-01-19 6:26 ` Michael Ellerman
2015-01-19 17:02 ` Ryan Grimm [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-01-19 17:52 Ryan Grimm
2015-01-20 2:10 ` Ian Munsie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54BD38BC.5040305@linux.vnet.ibm.com \
--to=grimm@linux.vnet.ibm.com \
--cc=imunsie@au1.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=michaele@au1.ibm.com \
--cc=mikey@neuling.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).