From: Alexander Graf <agraf@suse.de>
To: David Gibson <david@gibson.dropbear.id.au>,
benh@kernel.crashing.org, mpe@ellerman.id.au, paulus@samba.org
Cc: aik@ozlabs.ru, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org, mdroth@us.ibm.com
Subject: Re: [PATCH 4/5] powerpc: Cleanup KVM emulated load/store endian handling
Date: Wed, 04 Feb 2015 15:30:40 +0100 [thread overview]
Message-ID: <54D22D10.2040502@suse.de> (raw)
In-Reply-To: <1422941785-22557-5-git-send-email-david@gibson.dropbear.id.au>
On 03.02.15 06:36, David Gibson wrote:
> Sometimes the KVM code on powerpc needs to emulate load or store
> instructions from the guest, which can include both normal and byte
> reversed forms.
>
> We currently (AFAICT) handle this correctly, but some variable names are
> very misleading. In particular we use "is_bigendian" in several places to
> actually mean "is the IO the same endian as the host", but we now support
> little-endian powerpc hosts. This also ties into the misleadingly named
> ld_le*() and st_le*() functions, which in fact always byteswap, even on
> an LE host.
>
> This patch cleans this up by renaming to more accurate "host_swabbed", and
> uses the generic swab*() functions instead of the powerpc specific and
> misleadingly named ld_le*() and st_le*() functions.
>
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Alexander Graf <agraf@suse.de>
Alex
next prev parent reply other threads:[~2015-02-04 14:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-03 5:36 [PATCH 0/5] powerpc: Get rid of redundant arch specific swab functions David Gibson
2015-02-03 5:36 ` [PATCH 1/5] powerpc: Move Power Macintosh drivers to generic byteswappers David Gibson
2015-02-03 5:36 ` [PATCH 2/5] powerpc: Remove powerpc specific byteswap from bt8xx DVB driver David Gibson
2015-03-24 2:32 ` Benjamin Herrenschmidt
2015-02-03 5:36 ` [PATCH 3/5] powerpc: Remove arch specific byteswappers from the MXC MMC driver David Gibson
2015-02-03 5:36 ` [PATCH 4/5] powerpc: Cleanup KVM emulated load/store endian handling David Gibson
2015-02-04 14:30 ` Alexander Graf [this message]
2015-02-03 5:36 ` [PATCH 5/5] powerpc: Remove unused st_le*() and ld_le* functions David Gibson
2015-02-04 11:54 ` [PATCH 0/5] powerpc: Get rid of redundant arch specific swab functions David Laight
2015-02-04 13:41 ` 'David Gibson'
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54D22D10.2040502@suse.de \
--to=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=benh@kernel.crashing.org \
--cc=david@gibson.dropbear.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mdroth@us.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).