From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-by2-obe.outbound.protection.outlook.com (mail-by2on0141.outbound.protection.outlook.com [207.46.100.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 401441A0292 for ; Thu, 5 Feb 2015 09:17:52 +1100 (AEDT) Message-ID: <54D29A3E.9090201@Freescale.com> Date: Wed, 4 Feb 2015 16:16:30 -0600 From: Emil Medve MIME-Version: 1.0 To: Greg KH Subject: Re: [RFC 00/10] Freescale DPAA B/QMan drivers References: <1423061322-16059-1-git-send-email-Emilian.Medve@Freescale.com> <20150204184028.GA8061@kroah.com> In-Reply-To: <20150204184028.GA8061@kroah.com> Content-Type: text/plain; charset="windows-1252" Cc: devel@driverdev.osuosl.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hello Greg, Thanks for looking at this On 02/04/2015 12:40 PM, Greg KH wrote: > On Wed, Feb 04, 2015 at 08:48:32AM -0600, Emil Medve wrote: >> >> Hello, >> >> >> This is the first attempt to publish the Freescale DPAA B/QMan drivers. They are >> not to be applied yet. At this stage, this is more or less the drivers from the >> Freescale PowerPC SDK roughly squashed and split in a sequence of component >> patches. They still needs some work and cleanup before we expect to have them >> applied, but we appreciate early feedback > > First off, why put these in staging? What's keeping them from being > merged "properly"? I was thinking they'll go into drivers/soc. Past some cleanup and some integration issues, nothing holds them back > Secondly, if they are going to go into staging, then I need a TODO file > in the directory of the driver listing what needs to be done to move the > code out of staging, and who is responsible for the code. Ideally a > MAINTAINERS entry as well. Will get both lists, say, for the next post > And finally, staging drivers should be self-contained, your .h files: > >> include/linux/fsl_bman.h | 517 +++++ >> include/linux/fsl_qman.h | 1955 +++++++++++++++++ > > Need to be in drivers/staging// not in include/linux/ > espeically as nothing outside of your driver needs these .h files. These files contain the public interface(s) used by other devices connected to the B/QMan: FMan, PME, RMan, DCE, etc. Every driver/piece of code in need of a HW queue (QMan) or HW buffer allocator (BMan) will use these files Cheers,