From: nick <xerofoify@gmail.com>
To: benh@kernel.crashing.org
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Question about the function,andslcd_ioctl in the file,ans-lcd.c
Date: Wed, 04 Feb 2015 23:52:41 -0500 [thread overview]
Message-ID: <54D2F719.7020405@gmail.com> (raw)
Greetings Benjamin and others,
I am wondering why this code has not been removed:
for (; ch; temp++) { /* FIXME: This is ugly, but should work, as a \0 byte is not a valid command code */
anslcd_write_byte_ctrl ( ch );
__get_user(ch, temp);
}
As if we don't want to run a command code then why not break out of the case and
remove this loop as there is no need for it if we don't need to execute the call
to the function, anslcd_write_byte_ctrl to write the command code. Unless I am
missing something, I am assuming I can send in a patch removing this lines of
code.
Cheers Nick
reply other threads:[~2015-02-05 4:52 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54D2F719.7020405@gmail.com \
--to=xerofoify@gmail.com \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).