* Question about the function,andslcd_ioctl in the file,ans-lcd.c
@ 2015-02-05 4:52 nick
0 siblings, 0 replies; only message in thread
From: nick @ 2015-02-05 4:52 UTC (permalink / raw)
To: benh; +Cc: linuxppc-dev, linux-kernel
Greetings Benjamin and others,
I am wondering why this code has not been removed:
for (; ch; temp++) { /* FIXME: This is ugly, but should work, as a \0 byte is not a valid command code */
anslcd_write_byte_ctrl ( ch );
__get_user(ch, temp);
}
As if we don't want to run a command code then why not break out of the case and
remove this loop as there is no need for it if we don't need to execute the call
to the function, anslcd_write_byte_ctrl to write the command code. Unless I am
missing something, I am assuming I can send in a patch removing this lines of
code.
Cheers Nick
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2015-02-05 4:52 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-05 4:52 Question about the function,andslcd_ioctl in the file,ans-lcd.c nick
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).