From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 986BFE91269 for ; Thu, 5 Feb 2026 06:54:50 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4f67J85H1Dz2xrk; Thu, 05 Feb 2026 17:54:48 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip="2600:3c0a:e001:78e:0:1991:8:25" ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1770274488; cv=none; b=Bx+K7lOYJSBuQ8qLMQX+69aZMlKpM9K54NGPGZekrsmCwfv3dnKmgWuj/wRBhiuI79mb54BV/y/4nXWlJqHE9eUZ9NwOh+XaCYQ6ACosqnUgN44Rakgnipg0Z+RVoNvmro4MRcwtG9/aIzR4NS+0ydksdChDRKmOohqsLTL/zpGchXqkosL4Bda7pzuOChri+QaRnqgQzeKuK+qTIPfqx329DU/lgR56x93eHWZCpWduqCmvVLFn8HN9/LeiSxr6v5RYh24KFRDikI9yABtEvFAFh+dx9704uwnycsqCOKzObZDFHeTwcDnh+CrmTvawxoooEi2ECH3T0pzagRJ8VA== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1770274488; c=relaxed/relaxed; bh=5T0ktCjmh8RZLUEP0esqkY26ecLoJfpVXJxSRbhD2VE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZQYMyAgcjc05yDXlbZZwBm51+eze1SX0N1vQSgtXs4wP2zqPy3IOmjrXRB01cTGY/9GeiUnhabq08J4G65lwRWa0xzOpEk+8qRuwprwJY/sZUMgcF4JegdiHJWyqaDF1CgUxvrVpI9g74FHnZ2Qswf9QWu/uk1xaDqKzlPRX1DAcv+BmF0qtSNAWLgCNyuEK3KA89rSrmx1sH1ZJ4H+8upKmgKB0dyc6qPNpob8qgsCHpvnxzZ0k+W2jeR2eBodLea71XHNvtOAWFn3s2shmnU5nNq6utnSXoNNLJP40F8QwRDEAdgafpuAIfJ5IHnvvUh7CIjPqMkHijQKRhN+k7A== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=YnI6RNMr; dkim-atps=neutral; spf=pass (client-ip=2600:3c0a:e001:78e:0:1991:8:25; helo=sea.source.kernel.org; envelope-from=chleroy@kernel.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=YnI6RNMr; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=2600:3c0a:e001:78e:0:1991:8:25; helo=sea.source.kernel.org; envelope-from=chleroy@kernel.org; receiver=lists.ozlabs.org) Received: from sea.source.kernel.org (sea.source.kernel.org [IPv6:2600:3c0a:e001:78e:0:1991:8:25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4f67J801fdz2xS5 for ; Thu, 05 Feb 2026 17:54:47 +1100 (AEDT) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 281CC43C1C; Thu, 5 Feb 2026 06:54:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E82EBC4CEF7; Thu, 5 Feb 2026 06:54:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770274485; bh=EEyaIS7c/Np/w/ayZ/fwd6oYNont392luQLgCjnHcqU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=YnI6RNMrjB8P3QuDfeXZj4xszCtFy0YMF+8N8ZMfymdZ9gx4glVSoc6aRgF77Vk35 GiPTaWQItTOr2z6lOoLDGYAUjBjrPbgaDWXzlw0W95uqE9vFGCkxQS5qrtPD/46hW5 lTcRlZnhqDGHWw0Qh8GmOmADpM6NsRyEaOTZLcrli79mJ0YkVDip7IgU/J2yIegRsg jy25oKzOzuDLytA6X0XcVplJ2qcU+RDYgJBZBGeVhxbAvHmnUWr/epxFrwQLqomGMv nhXo0pvsdNRyyP+iVz1jw1cSNd1jN5v4rzs6EpgYzQBU/Qgs+SNAo3W6MLBHabzMRN TqZfvChTSpuBg== Message-ID: <54bf1026-7d71-466d-b6c0-8714c7230f9f@kernel.org> Date: Thu, 5 Feb 2026 07:54:41 +0100 X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net] net: wan/fsl_ucc_hdlc: Fix dma_free_coherent() in uhdlc_memclean() To: Thomas Fourier Cc: stable@vger.kernel.org, Zhao Qiang , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <20260204162548.94160-3-fourier.thomas@gmail.com> Content-Language: fr-FR From: "Christophe Leroy (CS GROUP)" In-Reply-To: <20260204162548.94160-3-fourier.thomas@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Le 04/02/2026 à 17:25, Thomas Fourier a écrit : > [Vous ne recevez pas souvent de courriers de fourier.thomas@gmail.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] > > The priv->rx_buffer and priv->dma_rx_addr are alloc'd together as You mean priv->rx_buffer and priv->tx_buffer I guess. > contiguous buffers in uhdlc_init() but freed as two buffers in > uhdlc_memclean(). > > Change the cleanup to only call dma_free_coherent() once on the whole > buffer. > > Fixes: c19b6d246a35 ("drivers/net: support hdlc function for QE-UCC") > Cc: > Signed-off-by: Thomas Fourier > --- > drivers/net/wan/fsl_ucc_hdlc.c | 10 +--------- > 1 file changed, 1 insertion(+), 9 deletions(-) > > diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c > index f999798a5612..59cd861d13d6 100644 > --- a/drivers/net/wan/fsl_ucc_hdlc.c > +++ b/drivers/net/wan/fsl_ucc_hdlc.c > @@ -790,19 +790,11 @@ static void uhdlc_memclean(struct ucc_hdlc_private *priv) > > if (priv->rx_buffer) { > dma_free_coherent(priv->dev, > - RX_BD_RING_LEN * MAX_RX_BUF_LENGTH, > + (RX_BD_RING_LEN + TX_BD_RING_LEN) * MAX_RX_BUF_LENGTH, > priv->rx_buffer, priv->dma_rx_addr); > priv->rx_buffer = NULL; > priv->dma_rx_addr = 0; You also have to do: priv->tx_buffer = NULL; priv->dma_tx_addr = 0; Which that and commit message fixed you can add Reviewed-by: Christophe Leroy (CS GROUP) > } > - > - if (priv->tx_buffer) { > - dma_free_coherent(priv->dev, > - TX_BD_RING_LEN * MAX_RX_BUF_LENGTH, > - priv->tx_buffer, priv->dma_tx_addr); > - priv->tx_buffer = NULL; > - priv->dma_tx_addr = 0; > - } > } > > static int uhdlc_close(struct net_device *dev) > -- > 2.43.0 > >