From: Alexey Kardashevskiy <aik@ozlabs.ru>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Thomas Huth <thuth@linux.vnet.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org,
Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH SLOF] pci-properties: Remove redundant call to device-type
Date: Wed, 11 Mar 2015 20:13:11 +1100 [thread overview]
Message-ID: <55000727.4010203@ozlabs.ru> (raw)
In-Reply-To: <1426062062.17565.22.camel@kernel.crashing.org>
On 03/11/2015 07:21 PM, Benjamin Herrenschmidt wrote:
> On Wed, 2015-03-11 at 08:50 +0100, Thomas Huth wrote:
>>
>> - Graphic cards should get the "display" device_type ... I guess
>> that's
>> missing now?
>
> At least the code for qemu-vga does it
>
>> - pci bus nodes (like bridges) should get the "pci" device_type
>> according to the Open Firmware PCI binding, is this still the case?
>
> Ah yes we need to check that, specifically P2P bridges
>
>> - Seems like there are some other devices with device_type property
>> where SLOF does not provide an implemented interface, like in
>> slof/fs/usb/dev-mouse.fs ... should these be revised, too?
>
> not a *huge* issue but we can look into it when needed.
Then I better remove it now as well, any reason to wait for "when needed"?
--
Alexey
next prev parent reply other threads:[~2015-03-11 9:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-11 6:26 [PATCH SLOF] pci-properties: Remove redundant call to device-type Alexey Kardashevskiy
2015-03-11 7:50 ` Thomas Huth
2015-03-11 8:21 ` Benjamin Herrenschmidt
2015-03-11 8:30 ` Thomas Huth
2015-03-11 9:13 ` Alexey Kardashevskiy [this message]
2015-03-11 8:34 ` Nikunj A Dadhania
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55000727.4010203@ozlabs.ru \
--to=aik@ozlabs.ru \
--cc=benh@kernel.crashing.org \
--cc=david@gibson.dropbear.id.au \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nikunj@linux.vnet.ibm.com \
--cc=thuth@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).