From: Anshuman Khandual <khandual@linux.vnet.ibm.com>
To: Sam Bobroff <sam.bobroff@au1.ibm.com>,
mpe@ellerman.id.au, benh@kernel.crashing.org
Cc: mikey@neuling.org, azanella@linux.vnet.ibm.com,
linuxppc-dev@lists.ozlabs.org, matt@ozlabs.org
Subject: Re: [PATCH 1/3] powerpc/tm: Abort syscalls in active transactions
Date: Fri, 20 Mar 2015 14:34:43 +0530 [thread overview]
Message-ID: <550BE2AB.2050604@linux.vnet.ibm.com> (raw)
In-Reply-To: <6ebcb9f982f7cb100aef954cd7dc6a6081cd9134.1426740212.git.sam.bobroff@au1.ibm.com>
On 03/19/2015 10:13 AM, Sam Bobroff wrote:
> This patch changes the syscall handler to doom (tabort) active
> transactions when a syscall is made and return immediately without
> performing the syscall.
>
> Currently, the system call instruction automatically suspends an
> active transaction which causes side effects to persist when an active
> transaction fails.
>
> This does change the kernel's behaviour, but in a way that was
> documented as unsupported. It doesn't reduce functionality because
> syscalls will still be performed after tsuspend. It also provides a
> consistent interface and makes the behaviour of user code
> substantially the same across powerpc and platforms that do not
> support suspended transactions (e.g. x86 and s390).
>
> Performance measurements using
> http://ozlabs.org/~anton/junkcode/null_syscall.c
> indicate the cost of a system call increases by about 0.5%.
Performance test results verified which shows an improvement of
around ~0.52% with the patch compared to without it.
[With patch] null_syscall: 757.59 cycles 100.00%
[Without patch]] null_syscall: 753.66 cycles 100.00%
>
> Signed-off-by: Sam Bobroff <sam.bobroff@au1.ibm.com>
Tested-by: Anshuman Khandual <khandual@linux.vnet.ibm.com>
next prev parent reply other threads:[~2015-03-20 9:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 4:43 [PATCH 0/3] powerpc/tm: Abort syscalls in active transactions Sam Bobroff
2015-03-19 4:43 ` [PATCH 1/3] " Sam Bobroff
2015-03-19 5:01 ` Michael Neuling
2015-03-20 9:04 ` Anshuman Khandual [this message]
2015-03-24 2:04 ` Michael Ellerman
2015-03-24 4:26 ` Anshuman Khandual
2015-03-24 13:02 ` Michael Ellerman
2015-03-19 4:43 ` [PATCH 2/3] selftests/powerpc: Move get_auxv_entry() to harness.c Sam Bobroff
2015-03-19 4:43 ` [PATCH 3/3] selftests/powerpc: Add transactional syscall test Sam Bobroff
2015-03-20 9:25 ` Anshuman Khandual
2015-03-24 1:52 ` Sam Bobroff
2015-03-24 2:02 ` Michael Ellerman
2015-03-30 0:06 ` Sam Bobroff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550BE2AB.2050604@linux.vnet.ibm.com \
--to=khandual@linux.vnet.ibm.com \
--cc=azanella@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=matt@ozlabs.org \
--cc=mikey@neuling.org \
--cc=mpe@ellerman.id.au \
--cc=sam.bobroff@au1.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).